Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
+#include "base/threading/thread_restrictions.h"
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/launch_util.h"
 #include "chrome/browser/first_run/first_run.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/lifetime/keep_alive_types.h"
@@ skipping 416 matching lines @@
 
 #if !defined(OS_CHROMEOS)
 IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, StartupURLsForTwoProfiles) {
   Profile* default_profile = browser()->profile();
 
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   // Create another profile.
   base::FilePath dest_path = profile_manager->user_data_dir();
   dest_path = dest_path.Append(FILE_PATH_LITERAL("New Profile 1"));
 
-  Profile* other_profile = profile_manager->GetProfile(dest_path);
+  Profile* other_profile = nullptr;
+  {
+    base::ThreadRestrictions::ScopedAllowIO allow_io;
+    other_profile = profile_manager->GetProfile(dest_path);
+  }
   ASSERT_TRUE(other_profile);
 
   // Use a couple arbitrary URLs.
   std::vector<GURL> urls1;
   urls1.push_back(ui_test_utils::GetTestUrl(
       base::FilePath(base::FilePath::kCurrentDirectory),
       base::FilePath(FILE_PATH_LITERAL("title1.html"))));
   std::vector<GURL> urls2;
   urls2.push_back(ui_test_utils::GetTestUrl(
       base::FilePath(base::FilePath::kCurrentDirectory),
@@ skipping 165 matching lines @@
   // Create 4 more profiles.
   base::FilePath dest_path1 = profile_manager->user_data_dir().Append(
       FILE_PATH_LITERAL("New Profile 1"));
   base::FilePath dest_path2 = profile_manager->user_data_dir().Append(
       FILE_PATH_LITERAL("New Profile 2"));
   base::FilePath dest_path3 = profile_manager->user_data_dir().Append(
       FILE_PATH_LITERAL("New Profile 3"));
   base::FilePath dest_path4 = profile_manager->user_data_dir().Append(
       FILE_PATH_LITERAL("New Profile 4"));
 
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   Profile* profile_home1 = profile_manager->GetProfile(dest_path1);
   ASSERT_TRUE(profile_home1);
   Profile* profile_home2 = profile_manager->GetProfile(dest_path2);
   ASSERT_TRUE(profile_home2);
   Profile* profile_last = profile_manager->GetProfile(dest_path3);
   ASSERT_TRUE(profile_last);
   Profile* profile_urls = profile_manager->GetProfile(dest_path4);
   ASSERT_TRUE(profile_urls);
 
   DisableWelcomePages(
@@ skipping 88 matching lines @@
   ProfileManager* profile_manager = g_browser_process->profile_manager();
 
   // Create 3 profiles.
   base::FilePath dest_path1 = profile_manager->user_data_dir().Append(
       FILE_PATH_LITERAL("New Profile 1"));
   base::FilePath dest_path2 = profile_manager->user_data_dir().Append(
       FILE_PATH_LITERAL("New Profile 2"));
   base::FilePath dest_path3 = profile_manager->user_data_dir().Append(
       FILE_PATH_LITERAL("New Profile 3"));
 
-  Profile* profile_home = profile_manager->GetProfile(dest_path1);
-  ASSERT_TRUE(profile_home);
-  Profile* profile_last = profile_manager->GetProfile(dest_path2);
-  ASSERT_TRUE(profile_last);
-  Profile* profile_urls = profile_manager->GetProfile(dest_path3);
-  ASSERT_TRUE(profile_urls);
+  Profile* profile_home = nullptr;
+  Profile* profile_last = nullptr;
+  Profile* profile_urls = nullptr;
+  {
+    base::ThreadRestrictions::ScopedAllowIO allow_io;
+    profile_home = profile_manager->GetProfile(dest_path1);
+    ASSERT_TRUE(profile_home);
+    profile_last = profile_manager->GetProfile(dest_path2);
+    ASSERT_TRUE(profile_last);
+    profile_urls = profile_manager->GetProfile(dest_path3);
+    ASSERT_TRUE(profile_urls);
+  }
 
   // Set the profiles to open the home page, last visited pages or URLs.
   SessionStartupPref pref_home(SessionStartupPref::DEFAULT);
   SessionStartupPref::SetStartupPref(profile_home, pref_home);
 
   SessionStartupPref pref_last(SessionStartupPref::LAST);
   SessionStartupPref::SetStartupPref(profile_last, pref_last);
 
   std::vector<GURL> urls;
   urls.push_back(ui_test_utils::GetTestUrl(
@@ skipping 298 matching lines @@
 #define MAYBE_WelcomePages WelcomePages
 #endif
 IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorFirstRunTest, MAYBE_WelcomePages) {
   ASSERT_TRUE(embedded_test_server()->Start());
 
   ProfileManager* profile_manager = g_browser_process->profile_manager();
 
   // Open the two profiles.
   base::FilePath dest_path = profile_manager->user_data_dir();
 
-  Profile* profile1 = Profile::CreateProfile(
-      dest_path.Append(FILE_PATH_LITERAL("New Profile 1")), nullptr,
-      Profile::CreateMode::CREATE_MODE_SYNCHRONOUS);
+  Profile* profile1 = nullptr;
+  {
+    base::ThreadRestrictions::ScopedAllowIO allow_io;
+    profile1 = Profile::CreateProfile(
+        dest_path.Append(FILE_PATH_LITERAL("New Profile 1")), nullptr,
+        Profile::CreateMode::CREATE_MODE_SYNCHRONOUS);
+  }
   ASSERT_TRUE(profile1);
   profile_manager->RegisterTestingProfile(profile1, true, false);
 
   Browser* browser = OpenNewBrowser(profile1);
   ASSERT_TRUE(browser);
 
   TabStripModel* tab_strip = browser->tab_strip_model();
 
   // Windows 10 has its own Welcome page; the standard Welcome page does not
   // appear until second run.
@@ skipping 17 matching lines @@
   ASSERT_TRUE(browser);
   tab_strip = browser->tab_strip_model();
 
   // Ensure that the new tab page appears on subsequent runs.
   ASSERT_EQ(1, tab_strip->count());
   EXPECT_EQ("chrome://newtab/",
             tab_strip->GetWebContentsAt(0)->GetURL().possibly_invalid_spec());
 }
 
 #endif  // !defined(OS_CHROMEOS)