Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

chrome/browser/sync/test/integration/sync_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/test/integration/sync_test.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <limits>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/guid.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/process/launch.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/test/test_timeouts.h"
 #include "base/threading/platform_thread.h"
+#include "base/threading/thread_restrictions.h"
 #include "base/values.h"
 #include "build/build_config.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/invalidation/profile_invalidation_provider_factory.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
@@ skipping 293 matching lines @@
   content::WebContents* contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   content::NavigationEntry* entry = contents->GetController().GetVisibleEntry();
   CHECK(entry) << "Could not get a hold on NavigationEntry post URL navigate.";
   DVLOG(1) << "Create Gaia account request return code = "
       << entry->GetHttpStatusCode();
   return entry->GetHttpStatusCode() == 200;
 }
 
 void SyncTest::CreateProfile(int index) {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   tmp_profile_paths_[index] = new base::ScopedTempDir();
   if (UsingExternalServers() && num_clients_ > 1) {
     // For multi profile UI signin, profile paths should be outside user data
     // dir to allow signing-in multiple profiles to same account. Otherwise, we
     // get an error that the profile has already signed in on this device.
     CHECK(tmp_profile_paths_[index]->CreateUniqueTempDir());
   } else {
     // Create new profiles in user data dir so that other profiles can know
     // about it. This is needed in tests such as supervised user cases which
     // assume browser->profile() as the custodian profile.
@@ skipping 146 matching lines @@
   if (verifier_ == nullptr)
     LOG(FATAL) << "SetupClients() has not yet been called.";
   return verifier_;
 }
 
 void SyncTest::DisableVerifier() {
   use_verifier_ = false;
 }
 
 bool SyncTest::SetupClients() {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   if (num_clients_ <= 0)
     LOG(FATAL) << "num_clients_ incorrectly initialized.";
   if (!profiles_.empty() || !browsers_.empty() || !clients_.empty())
     LOG(FATAL) << "SetupClients() has already been called.";
 
   // Create the required number of sync profiles, browsers and clients.
   profiles_.resize(num_clients_);
   profile_delegates_.resize(num_clients_ + 1);  // + 1 for the verifier.
   tmp_profile_paths_.resize(num_clients_);
   clients_.resize(num_clients_);
@@ skipping 122 matching lines @@
     p2p_invalidation_service->UpdateCredentials(username_, password_);
     // Start listening for and emitting notifications of commits.
     DCHECK(!invalidation_forwarders_[index]);
     invalidation_forwarders_[index] =
         base::MakeUnique<P2PInvalidationForwarder>(clients_[index]->service(),
                                                    p2p_invalidation_service);
   }
 }
 
 bool SyncTest::SetupSync() {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   // Create sync profiles and clients if they haven't already been created.
   if (profiles_.empty()) {
     if (!SetupClients()) {
       LOG(FATAL) << "SetupClients() failed.";
       return false;
     }
   }
 
   int clientIndex = 0;
   // If we're using external servers, clear server data so the account starts
@@ skipping 553 matching lines @@
 bool SyncTest::ClearServerData(ProfileSyncServiceHarness* harness) {
   // At this point our birthday is good.
   base::RunLoop run_loop;
   harness->service()->ClearServerDataForTest(run_loop.QuitClosure());
   run_loop.Run();
 
   // Our birthday is invalidated on the server here so restart sync to get
   // the new birthday from the server.
   return harness->RestartSyncService();
 }