Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

chrome/browser/spellchecker/spellcheck_service_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/spellchecker/spellcheck_service.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <string>
 #include <tuple>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/path_service.h"
 #include "base/run_loop.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/synchronization/waitable_event.h"
+#include "base/threading/thread_restrictions.h"
 #include "base/values.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/spellchecker/spellcheck_factory.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "components/prefs/pref_service.h"
 #include "components/spellcheck/browser/pref_names.h"
@@ skipping 231 matching lines @@
 
 // Tests that we can delete a corrupted BDICT file used by hunspell. We do not
 // run this test on Mac because Mac does not use hunspell by default.
 IN_PROC_BROWSER_TEST_F(SpellcheckServiceBrowserTest, DeleteCorruptedBDICT) {
   // Write the corrupted BDICT data to create a corrupted BDICT file.
   base::FilePath dict_dir;
   ASSERT_TRUE(PathService::Get(chrome::DIR_APP_DICTIONARIES, &dict_dir));
   base::FilePath bdict_path =
       spellcheck::GetVersionedFileName("en-US", dict_dir);
 
-  size_t actual = base::WriteFile(bdict_path,
-      reinterpret_cast<const char*>(kCorruptedBDICT),
-      arraysize(kCorruptedBDICT));
-  EXPECT_EQ(arraysize(kCorruptedBDICT), actual);
+  {
+    base::ThreadRestrictions::ScopedAllowIO allow_io;
+    size_t actual = base::WriteFile(
+        bdict_path, reinterpret_cast<const char*>(kCorruptedBDICT),
+        arraysize(kCorruptedBDICT));
+    EXPECT_EQ(arraysize(kCorruptedBDICT), actual);
+  }
 
   // Attach an event to the SpellcheckService object so we can receive its
   // status updates.
   base::WaitableEvent event(base::WaitableEvent::ResetPolicy::MANUAL,
                             base::WaitableEvent::InitialState::NOT_SIGNALED);
   SpellcheckService::AttachStatusEvent(&event);
 
   BrowserContext* context = GetContext();
 
   // Ensure that the SpellcheckService object does not already exist. Otherwise
@@ skipping 11 matching lines @@
   // The SpellCheckHost object will send a BDICT_CORRUPTED event.
   SpellcheckServiceFactory::GetForContext(context);
 
   // Check the received event. Also we check if Chrome has successfully deleted
   // the corrupted dictionary. We delete the corrupted dictionary to avoid
   // leaking it when this test fails.
   content::RunAllPendingInMessageLoop(content::BrowserThread::FILE);
   content::RunAllPendingInMessageLoop(content::BrowserThread::UI);
   EXPECT_EQ(SpellcheckService::BDICT_CORRUPTED,
             SpellcheckService::GetStatusEvent());
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   if (base::PathExists(bdict_path)) {
     ADD_FAILURE();
     EXPECT_TRUE(base::DeleteFile(bdict_path, true));
   }
 }
 
 // Checks that preferences migrate correctly.
 IN_PROC_BROWSER_TEST_F(SpellcheckServiceBrowserTest, PreferencesMigrated) {
   GetPrefs()->Set(spellcheck::prefs::kSpellCheckDictionaries,
                   base::ListValue());
@@ skipping 71 matching lines @@
   std::string pref;
   ASSERT_TRUE(GetPrefs()
                   ->GetList(spellcheck::prefs::kSpellCheckDictionaries)
                   ->GetString(0, &pref));
   EXPECT_EQ("en-US", pref);
   ASSERT_TRUE(GetPrefs()
                   ->GetList(spellcheck::prefs::kSpellCheckDictionaries)
                   ->GetString(1, &pref));
   EXPECT_EQ("fr", pref);
 }