Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

chrome/browser/policy/test/local_policy_test_server.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/test/local_policy_test_server.h"
 
 #include <ctype.h>
 #include <stdint.h>
 
 #include <algorithm>
 #include <vector>
 
 #include "base/base_paths.h"
 #include "base/files/file_util.h"
 #include "base/json/json_writer.h"
 #include "base/memory/ptr_util.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/path_service.h"
 #include "base/strings/stringprintf.h"
+#include "base/threading/thread_restrictions.h"
 #include "base/values.h"
 #include "build/build_config.h"
 #include "components/policy/core/common/cloud/cloud_policy_constants.h"
 #include "crypto/rsa_private_key.h"
 #include "net/test/python_utils.h"
 
 namespace policy {
 
 namespace {
 
@@ skipping 26 matching lines @@
 bool IsUnsafeCharacter(char c) {
   return !(isalnum(c) || c == '.' || c == '@' || c == '-');
 }
 
 }  // namespace
 
 LocalPolicyTestServer::LocalPolicyTestServer()
     : net::LocalTestServer(net::BaseTestServer::TYPE_HTTP,
                            net::BaseTestServer::kLocalhost,
                            base::FilePath()) {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   CHECK(server_data_dir_.CreateUniqueTempDir());
   config_file_ = server_data_dir_.GetPath().Append(kPolicyFileName);
 }
 
 LocalPolicyTestServer::LocalPolicyTestServer(const base::FilePath& config_file)
     : net::LocalTestServer(net::BaseTestServer::TYPE_HTTP,
                            net::BaseTestServer::kLocalhost,
                            base::FilePath()),
       config_file_(config_file) {}
 
 LocalPolicyTestServer::LocalPolicyTestServer(const std::string& test_name)
     : net::LocalTestServer(net::BaseTestServer::TYPE_HTTP,
                            net::BaseTestServer::kLocalhost,
                            base::FilePath()) {
   // Read configuration from a file in chrome/test/data/policy.
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   base::FilePath source_root;
   CHECK(PathService::Get(base::DIR_SOURCE_ROOT, &source_root));
   config_file_ = source_root
       .AppendASCII("chrome")
       .AppendASCII("test")
       .AppendASCII("data")
       .AppendASCII("policy")
       .AppendASCII(base::StringPrintf("policy_%s.json", test_name.c_str()));
 }
 
 LocalPolicyTestServer::~LocalPolicyTestServer() {}
 
 bool LocalPolicyTestServer::SetSigningKeyAndSignature(
     const crypto::RSAPrivateKey* key, const std::string& signature) {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   CHECK(server_data_dir_.IsValid());
 
   std::vector<uint8_t> signing_key_bits;
   if (!key->ExportPrivateKey(&signing_key_bits))
     return false;
 
   policy_key_ = server_data_dir_.GetPath().Append(kSigningKeyFileName);
   int bytes_written = base::WriteFile(
       policy_key_, reinterpret_cast<const char*>(signing_key_bits.data()),
       signing_key_bits.size());
@@ skipping 35 matching lines @@
   types->AppendString(dm_protocol::kChromeExtensionPolicyType);
   types->AppendString(dm_protocol::kChromeSigninExtensionPolicyType);
 
   client_dict->Set(kClientStateKeyAllowedPolicyTypes, types.release());
   clients_.Set(dm_token, client_dict.release());
 }
 
 bool LocalPolicyTestServer::UpdatePolicy(const std::string& type,
                                          const std::string& entity_id,
                                          const std::string& policy) {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   CHECK(server_data_dir_.IsValid());
 
   std::string selector = GetSelector(type, entity_id);
   base::FilePath policy_file = server_data_dir_.GetPath().AppendASCII(
       base::StringPrintf("policy_%s.bin", selector.c_str()));
 
   return base::WriteFile(policy_file, policy.c_str(), policy.size()) ==
          base::checked_cast<int>(policy.size());
 }
 
 bool LocalPolicyTestServer::UpdatePolicyData(const std::string& type,
                                              const std::string& entity_id,
                                              const std::string& data) {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   CHECK(server_data_dir_.IsValid());
 
   std::string selector = GetSelector(type, entity_id);
   base::FilePath data_file = server_data_dir_.GetPath().AppendASCII(
       base::StringPrintf("policy_%s.data", selector.c_str()));
 
   return base::WriteFile(data_file, data.c_str(), data.size()) ==
          base::checked_cast<int>(data.size());
 }
 
 GURL LocalPolicyTestServer::GetServiceURL() const {
   return GetURL("device_management");
 }
 
 bool LocalPolicyTestServer::SetPythonPath() const {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   if (!net::LocalTestServer::SetPythonPath())
     return false;
 
   // Add the net/tools/testserver directory to the path.
   base::FilePath net_testserver_path;
   if (!LocalTestServer::GetTestServerPath(&net_testserver_path)) {
     LOG(ERROR) << "Failed to get net testserver path.";
     return false;
   }
   AppendToPythonPath(net_testserver_path.DirName());
@@ skipping 27 matching lines @@
                      .AppendASCII("chromeos")
                      .AppendASCII("policy")
                      .AppendASCII("proto"));
 #endif
 
   return true;
 }
 
 bool LocalPolicyTestServer::GetTestServerPath(
     base::FilePath* testserver_path) const {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   base::FilePath source_root;
   if (!PathService::Get(base::DIR_SOURCE_ROOT, &source_root)) {
     LOG(ERROR) << "Failed to get DIR_SOURCE_ROOT";
     return false;
   }
   *testserver_path = source_root
       .AppendASCII("chrome")
       .AppendASCII("browser")
       .AppendASCII("policy")
       .AppendASCII("test")
       .AppendASCII("policy_testserver.py");
   return true;
 }
 
 bool LocalPolicyTestServer::GenerateAdditionalArguments(
     base::DictionaryValue* arguments) const {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   if (!net::LocalTestServer::GenerateAdditionalArguments(arguments))
     return false;
 
   arguments->SetString("config-file", config_file_.AsUTF8Unsafe());
   if (!policy_key_.empty())
     arguments->SetString("policy-key", policy_key_.AsUTF8Unsafe());
   if (automatic_rotation_of_signing_keys_enabled_) {
     arguments->Set("rotate-policy-keys-automatically",
                    base::MakeUnique<base::Value>());
   }
@@ skipping 19 matching lines @@
 std::string LocalPolicyTestServer::GetSelector(const std::string& type,
                                                const std::string& entity_id) {
   std::string selector = type;
   if (!entity_id.empty())
     selector = base::StringPrintf("%s/%s", type.c_str(), entity_id.c_str());
   std::replace_if(selector.begin(), selector.end(), IsUnsafeCharacter, '_');
   return selector;
 }
 
 }  // namespace policy