Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

chrome/browser/pdf/pdf_extension_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <vector>
 
 #include "base/base_paths.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/file_util.h"
 #include "base/hash.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/path_service.h"
 #include "base/strings/pattern.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/threading/thread_restrictions.h"
 #include "build/build_config.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/component_loader.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/pdf/pdf_extension_test_util.h"
 #include "chrome/browser/pdf/pdf_extension_util.h"
 #include "chrome/browser/plugins/plugin_prefs.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 105 matching lines @@
 
     GURL url(embedded_test_server()->GetURL("/pdf/" + pdf_filename));
 
     // It should be good enough to just navigate to the URL. But loading up the
     // BrowserPluginGuest seems to happen asynchronously as there was flakiness
     // being seen due to the BrowserPluginGuest not being available yet (see
     // crbug.com/498077). So instead use |LoadPdf| which ensures that the PDF is
     // loaded before continuing.
     WebContents* guest_contents = LoadPdfGetGuestContents(url);
     ASSERT_TRUE(guest_contents);
+    std::string test_util_js;
 
-    base::FilePath test_data_dir;
-    PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir);
-    test_data_dir = test_data_dir.Append(FILE_PATH_LITERAL("pdf"));
-    base::FilePath test_util_path = test_data_dir.AppendASCII("test_util.js");
-    std::string test_util_js;
-    ASSERT_TRUE(base::ReadFileToString(test_util_path, &test_util_js));
+    {
+      base::ThreadRestrictions::ScopedAllowIO allow_io;
+      base::FilePath test_data_dir;
+      PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir);
+      test_data_dir = test_data_dir.Append(FILE_PATH_LITERAL("pdf"));
+      base::FilePath test_util_path = test_data_dir.AppendASCII("test_util.js");
+      ASSERT_TRUE(base::ReadFileToString(test_util_path, &test_util_js));
 
-    base::FilePath test_file_path = test_data_dir.AppendASCII(filename);
-    std::string test_js;
-    ASSERT_TRUE(base::ReadFileToString(test_file_path, &test_js));
+      base::FilePath test_file_path = test_data_dir.AppendASCII(filename);
+      std::string test_js;
+      ASSERT_TRUE(base::ReadFileToString(test_file_path, &test_js));
 
-    test_util_js.append(test_js);
+      test_util_js.append(test_js);
+    }
+
     ASSERT_TRUE(content::ExecuteScript(guest_contents, test_util_js));
 
     if (!catcher.GetNextResult())
       FAIL() << catcher.message();
   }
 
   // Load the PDF at the given URL and use the PDFScriptingAPI to ensure it has
   // finished loading. Return true if it loads successfully or false if it
   // fails. If it doesn't finish loading the test will hang. This is done from
   // outside of the BrowserPlugin guest to ensure the PDFScriptingAPI works
@@ skipping 14 matching lines @@
     content::BrowserPluginGuestManager* guest_manager =
         contents->GetBrowserContext()->GetGuestManager();
     WebContents* guest_contents = guest_manager->GetFullPageGuest(contents);
     return guest_contents;
   }
 
   // Load all the PDFs contained in chrome/test/data/<dir_name>. This only runs
   // the test if base::Hash(filename) mod kNumberLoadTestParts == k in order
   // to shard the files evenly across values of k in [0, kNumberLoadTestParts).
   void LoadAllPdfsTest(const std::string& dir_name, int k) {
+    base::ThreadRestrictions::ScopedAllowIO allow_io;
     base::FilePath test_data_dir;
     ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir));
     base::FileEnumerator file_enumerator(test_data_dir.AppendASCII(dir_name),
                                          false, base::FileEnumerator::FILES,
                                          FILE_PATH_LITERAL("*.pdf"));
 
     size_t count = 0;
     for (base::FilePath file_path = file_enumerator.Next(); !file_path.empty();
          file_path = file_enumerator.Next()) {
       std::string filename = file_path.BaseName().MaybeAsASCII();
@@ skipping 264 matching lines @@
   GURL forbiddenUrl(
       "chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html?"
       "https://example.com/notrequested.pdf");
   ui_test_utils::NavigateToURL(browser(), forbiddenUrl);
 
   console_delegate->Wait();
 }
 
 // This test ensures that PDF can be loaded from local file
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, EnsurePDFFromLocalFileLoads) {
-  base::FilePath test_data_dir;
-  ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir));
-  test_data_dir = test_data_dir.Append(FILE_PATH_LITERAL("pdf"));
-  base::FilePath test_data_file = test_data_dir.AppendASCII("test.pdf");
-  ASSERT_TRUE(PathExists(test_data_file));
-  GURL test_pdf_url("file://" + test_data_file.MaybeAsASCII());
+  GURL test_pdf_url;
+  {
+    base::ThreadRestrictions::ScopedAllowIO allow_io;
+    base::FilePath test_data_dir;
+    ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir));
+    test_data_dir = test_data_dir.Append(FILE_PATH_LITERAL("pdf"));
+    base::FilePath test_data_file = test_data_dir.AppendASCII("test.pdf");
+    ASSERT_TRUE(PathExists(test_data_file));
+    test_pdf_url = GURL("file://" + test_data_file.MaybeAsASCII());
+  }
   WebContents* guest_contents = LoadPdfGetGuestContents(test_pdf_url);
   ASSERT_TRUE(guest_contents);
 }
 
 // This test ensures that link permissions are enforced properly in PDFs.
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, LinkPermissions) {
   GURL test_pdf_url(embedded_test_server()->GetURL("/pdf/test.pdf"));
   WebContents* guest_contents = LoadPdfGetGuestContents(test_pdf_url);
   ASSERT_TRUE(guest_contents);
 
@@ skipping 523 matching lines @@
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, OpenFromFTP) {
   net::SpawnedTestServer ftp_server(
       net::SpawnedTestServer::TYPE_FTP, net::SpawnedTestServer::kLocalhost,
       base::FilePath(FILE_PATH_LITERAL("chrome/test/data/pdf")));
   ASSERT_TRUE(ftp_server.Start());
 
   GURL url(ftp_server.GetURL("/test.pdf"));
   ASSERT_TRUE(LoadPdf(url));
   EXPECT_EQ(base::ASCIIToUTF16("test.pdf"), GetActiveWebContents()->GetTitle());
 }