Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)
Patch Set: ready for review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/scoped_temp_dir.h" 5 #include "base/files/scoped_temp_dir.h"
6 #include "base/macros.h" 6 #include "base/macros.h"
7 #include "base/test/histogram_tester.h" 7 #include "base/test/histogram_tester.h"
8 #include "base/threading/thread_restrictions.h"
8 #include "base/time/time.h" 9 #include "base/time/time.h"
9 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h" 10 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
10 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h" 11 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"
11 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 12 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
12 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h" 13 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
13 #include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load _metrics_observer.h" 14 #include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load _metrics_observer.h"
14 #include "chrome/browser/page_load_metrics/page_load_tracker.h" 15 #include "chrome/browser/page_load_metrics/page_load_tracker.h"
15 #include "chrome/browser/prerender/prerender_histograms.h" 16 #include "chrome/browser/prerender/prerender_histograms.h"
16 #include "chrome/browser/prerender/prerender_origin.h" 17 #include "chrome/browser/prerender/prerender_origin.h"
17 #include "chrome/browser/profiles/profile.h" 18 #include "chrome/browser/profiles/profile.h"
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 313
313 ui_test_utils::NavigateToURL(browser(), 314 ui_test_utils::NavigateToURL(browser(),
314 embedded_test_server()->GetURL("/page204.html")); 315 embedded_test_server()->GetURL("/page204.html"));
315 NavigateToUntrackedUrl(); 316 NavigateToUntrackedUrl();
316 EXPECT_TRUE(NoPageLoadMetricsRecorded()); 317 EXPECT_TRUE(NoPageLoadMetricsRecorded());
317 } 318 }
318 319
319 IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, IgnoreDownloads) { 320 IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, IgnoreDownloads) {
320 ASSERT_TRUE(embedded_test_server()->Start()); 321 ASSERT_TRUE(embedded_test_server()->Start());
321 322
323 base::ThreadRestrictions::ScopedAllowIO allow_io;
322 base::ScopedTempDir downloads_directory; 324 base::ScopedTempDir downloads_directory;
323 ASSERT_TRUE(downloads_directory.CreateUniqueTempDir()); 325 ASSERT_TRUE(downloads_directory.CreateUniqueTempDir());
324 browser()->profile()->GetPrefs()->SetFilePath( 326 browser()->profile()->GetPrefs()->SetFilePath(
325 prefs::kDownloadDefaultDirectory, downloads_directory.GetPath()); 327 prefs::kDownloadDefaultDirectory, downloads_directory.GetPath());
326 content::DownloadTestObserverTerminal downloads_observer( 328 content::DownloadTestObserverTerminal downloads_observer(
327 content::BrowserContext::GetDownloadManager(browser()->profile()), 329 content::BrowserContext::GetDownloadManager(browser()->profile()),
328 1, // == wait_count (only waiting for "download-test3.gif"). 330 1, // == wait_count (only waiting for "download-test3.gif").
329 content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL); 331 content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL);
330 332
331 ui_test_utils::NavigateToURL( 333 ui_test_utils::NavigateToURL(
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
783 ui_test_utils::NavigateToURL(browser(), embedded_test_server()->GetURL( 785 ui_test_utils::NavigateToURL(browser(), embedded_test_server()->GetURL(
784 "/page_load_metrics/large.html")); 786 "/page_load_metrics/large.html"));
785 NavigateToUntrackedUrl(); 787 NavigateToUntrackedUrl();
786 788
787 histogram_tester_.ExpectTotalCount(internal::kHistogramTotalBytes, 1); 789 histogram_tester_.ExpectTotalCount(internal::kHistogramTotalBytes, 1);
788 790
789 // Verify that there is a single sample recorded in the 10kB bucket (the size 791 // Verify that there is a single sample recorded in the 10kB bucket (the size
790 // of the main HTML response). 792 // of the main HTML response).
791 histogram_tester_.ExpectBucketCount(internal::kHistogramTotalBytes, 10, 1); 793 histogram_tester_.ExpectBucketCount(internal::kHistogramTotalBytes, 10, 1);
792 } 794 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698