Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include "base/auto_reset.h"
 #include "base/callback.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/json/json_writer.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/path_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/test_timeouts.h"
+#include "base/threading/thread_restrictions.h"
 #include "base/values.h"
 #include "build/build_config.h"
 #include "chrome/browser/apps/app_browsertest_util.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/api/media_galleries/media_galleries_api.h"
 #include "chrome/browser/media_galleries/media_file_system_registry.h"
 #include "chrome/browser/media_galleries/media_galleries_preferences.h"
 #include "chrome/browser/media_galleries/media_galleries_test_util.h"
 #include "chrome/browser/ui/extensions/app_launch_params.h"
 #include "chrome/browser/ui/extensions/application_launch.h"
@@ skipping 78 matching lines @@
 
   bool RunMediaGalleriesTestWithArg(const std::string& extension_name,
                                     const base::ListValue& custom_arg_value) {
     // Copy the test data for this test into a temporary directory. Then add
     // a common_injected.js to the temporary copy and run it.
     const char kTestDir[] = "api_test/media_galleries/";
     base::FilePath from_dir =
         test_data_dir_.AppendASCII(kTestDir + extension_name);
     from_dir = from_dir.NormalizePathSeparators();
 
+    base::ThreadRestrictions::ScopedAllowIO allow_io;
     base::ScopedTempDir temp_dir;
     if (!temp_dir.CreateUniqueTempDir())
       return false;
 
     if (!base::CopyDirectory(from_dir, temp_dir.GetPath(), true))
       return false;
 
     base::FilePath common_js_path(
         GetCommonDataDir().AppendASCII("common_injected.js"));
     base::FilePath inject_js_path(temp_dir.GetPath()
@@ skipping 40 matching lines @@
     for (MediaGalleriesPrefInfoMap::const_iterator it = galleries.begin();
          it != galleries.end(); ++it) {
       preferences->ForgetGalleryById(it->first);
     }
   }
 
   // This function makes a single fake gallery. This is needed to test platforms
   // with no default media galleries, such as CHROMEOS. This fake gallery is
   // pre-populated with a test.jpg and test.txt.
   void MakeSingleFakeGallery(MediaGalleryPrefId* pref_id) {
+    base::ThreadRestrictions::ScopedAllowIO allow_io;
     ASSERT_FALSE(fake_gallery_temp_dir_.IsValid());
     ASSERT_TRUE(fake_gallery_temp_dir_.CreateUniqueTempDir());
 
     MediaGalleriesPreferences* preferences = GetAndInitializePreferences();
 
     MediaGalleryPrefInfo gallery_info;
     ASSERT_FALSE(preferences->LookUpGalleryByPath(
         fake_gallery_temp_dir_.GetPath(), &gallery_info));
     MediaGalleryPrefId id = preferences->AddGallery(
         gallery_info.device_id,
@@ skipping 11 matching lines @@
     content::RunAllPendingInMessageLoop();
 
     // Valid file, should show up in JS as a FileEntry.
     AddFileToSingleFakeGallery(GetCommonDataDir().AppendASCII("test.jpg"));
 
     // Invalid file, should not show up as a FileEntry in JS at all.
     AddFileToSingleFakeGallery(GetCommonDataDir().AppendASCII("test.txt"));
   }
 
   void AddFileToSingleFakeGallery(const base::FilePath& source_path) {
+    base::ThreadRestrictions::ScopedAllowIO allow_io;
     ASSERT_TRUE(fake_gallery_temp_dir_.IsValid());
 
     ASSERT_TRUE(base::CopyFile(
         source_path,
         fake_gallery_temp_dir_.GetPath().Append(source_path.BaseName())));
   }
 
 #if defined(OS_WIN) || defined(OS_MACOSX)
   void PopulatePicasaTestData(const base::FilePath& picasa_app_data_root) {
+    base::ThreadRestrictions::ScopedAllowIO allow_io;
     base::FilePath picasa_database_path =
         picasa::MakePicasaDatabasePath(picasa_app_data_root);
     base::FilePath picasa_temp_dir_path =
         picasa_database_path.DirName().AppendASCII(picasa::kPicasaTempDirName);
     ASSERT_TRUE(base::CreateDirectory(picasa_database_path));
     ASSERT_TRUE(base::CreateDirectory(picasa_temp_dir_path));
 
     // Create fake folder directories.
     base::FilePath folders_root =
         ensure_media_directories_exists_->GetFakePicasaFoldersRootPath();
@@ skipping 199 matching lines @@
       ensure_media_directories_exists()->GetFakeAppDataPath());
 #endif
 
   base::ListValue custom_args;
   custom_args.AppendInteger(test_jpg_size());
   ASSERT_TRUE(RunMediaGalleriesTestWithArg("picasa", custom_args)) << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(MediaGalleriesPlatformAppBrowserTest,
                        MAYBE_PicasaCustomLocation) {
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   base::ScopedTempDir custom_picasa_app_data_root;
   ASSERT_TRUE(custom_picasa_app_data_root.CreateUniqueTempDir());
   ensure_media_directories_exists()->SetCustomPicasaAppDataPath(
       custom_picasa_app_data_root.GetPath());
   PopulatePicasaTestData(custom_picasa_app_data_root.GetPath());
 
   base::ListValue custom_args;
   custom_args.AppendInteger(test_jpg_size());
   ASSERT_TRUE(RunMediaGalleriesTestWithArg("picasa", custom_args)) << message_;
 }
@@ skipping 21 matching lines @@
 
   base::ListValue custom_args;
 #if BUILDFLAG(USE_PROPRIETARY_CODECS)
   custom_args.AppendBoolean(true);
 #else
   custom_args.AppendBoolean(false);
 #endif
   ASSERT_TRUE(RunMediaGalleriesTestWithArg("media_metadata", custom_args))
       << message_;
 }