Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: media/filters/decoder_stream.h

Issue 2835203006: media: Refactor VideoFrameStreamTest (Closed)
Patch Set: comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/decoder_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/decoder_stream.h
diff --git a/media/filters/decoder_stream.h b/media/filters/decoder_stream.h
index 28a11ebccc6644dfae8fd6950b9d05d1a8924b65..97ab9705e342091e3e8cf6aa01b890da05e8a062 100644
--- a/media/filters/decoder_stream.h
+++ b/media/filters/decoder_stream.h
@@ -106,12 +106,19 @@ class MEDIA_EXPORT DecoderStream {
// Allows callers to register for notification of config changes; this is
// called immediately after receiving the 'kConfigChanged' status from the
// DemuxerStream, before any action is taken to handle the config change.
- typedef base::Closure ConfigChangeObserverCB;
+ using ConfigChangeObserverCB = base::Closure;
void set_config_change_observer(
- const ConfigChangeObserverCB& config_change_observer) {
+ ConfigChangeObserverCB config_change_observer) {
config_change_observer_cb_ = config_change_observer;
}
+ // Allows tests to keep track the currently selected decoder.
+ using DecoderChangeObserverCB = base::RepeatingCallback<void(Decoder*)>;
+ void set_decoder_change_observer_for_testing(
+ DecoderChangeObserverCB decoder_change_observer_cb) {
+ decoder_change_observer_cb_ = std::move(decoder_change_observer_cb);
+ }
+
int get_pending_buffers_size_for_testing() const {
return pending_buffers_.size();
}
@@ -207,6 +214,7 @@ class MEDIA_EXPORT DecoderStream {
std::unique_ptr<DecryptingDemuxerStream> decrypting_demuxer_stream_;
ConfigChangeObserverCB config_change_observer_cb_;
+ DecoderChangeObserverCB decoder_change_observer_cb_;
// An end-of-stream buffer has been sent for decoding, no more buffers should
// be sent for decoding until it completes.
« no previous file with comments | « no previous file | media/filters/decoder_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698