Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: build/android/pylib/utils/decorators.py

Issue 2835203004: Fix logdog_wrapper to not upload if logdog binary does not exist. (Closed)
Patch Set: add a one liner to exception logging Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/test_wrapper/logdog_wrapper.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/utils/decorators.py
diff --git a/build/android/pylib/utils/decorators.py b/build/android/pylib/utils/decorators.py
index 8eec1d1e58e6da46517e7e64c05f917609ceac96..4247f9d741928d3c09cfe3826518da7234d46d17 100644
--- a/build/android/pylib/utils/decorators.py
+++ b/build/android/pylib/utils/decorators.py
@@ -32,6 +32,8 @@ def NoRaiseException(default_return_value=None, exception_message=''):
return f(*args, **kwargs)
except Exception: # pylint: disable=broad-except
logging.exception(exception_message)
+ logging.exception('The above exception is suppressed on purpose. '
jbudorick 2017/04/24 22:26:29 Could we just change the default exception_message
mikecase (-- gone --) 2017/04/24 22:33:40 Im not the biggest fan of this. If people are bein
BigBossZhiling 2017/04/25 18:13:47 Done.
+ 'It won\'t cause any crash.')
return default_return_value
return wrapper
return decorator
« no previous file with comments | « no previous file | build/android/test_wrapper/logdog_wrapper.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698