Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: milo/appengine/frontend/templates/pages/build.html

Issue 2835193006: Milo: Add timestamp name and tooltip (Closed)
Patch Set: Retrain, off-by-one Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/frontend/templates/pages/build.html
diff --git a/milo/appengine/frontend/templates/pages/build.html b/milo/appengine/frontend/templates/pages/build.html
index 39d1db164ac27dd85876285025b4fa5bed607ea7..bea3f39eddba2dda4a3895517f99ce8a60fdd751 100644
--- a/milo/appengine/frontend/templates/pages/build.html
+++ b/milo/appengine/frontend/templates/pages/build.html
@@ -153,7 +153,13 @@
<div class="status-{{.Status}} result">
<b>Steps</b>
{{ if .Duration -}}
- <span style="float:right">( {{ .Duration | humanDuration }} )</span>
+ <span style="float:right"
nodir 2017/04/29 01:26:40 probably we will have more places where we need to
hinoka 2017/05/02 03:33:14 the span might need other things though, like styl
nodir 2017/05/02 14:58:02 It might be premature generalization
+ class="duration"
+ data-starttime="{{ .Started | formatTime }}"
+ {{ if .Finished }}
+ data-endtime="{{ .Finished | formatTime }}"
+ {{ end }}>
+ ( {{ .Duration | humanDuration }} )</span>
{{- end }}
</div>
<ul>
@@ -170,7 +176,13 @@
<div class="status-{{.Status}} result">
<b>{{.Label}}</b>
{{ if .Duration -}}
- <span style="float:right">( {{ .Duration | humanDuration }} )</span>
+ <span style="float:right"
+ class="duration"
+ data-starttime="{{ .Started | formatTime }}"
+ {{ if .Finished }}
+ data-endtime="{{ .Finished | formatTime }}"
+ {{ end }}>
+ ( {{ .Duration | humanDuration }} )</span>
{{- end }}
<span>
{{ range .Text -}}

Powered by Google App Engine
This is Rietveld 408576698