Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.cc

Issue 2835193005: Offline Pages - Policy cleanup (Closed)
Patch Set: add background loader offliner. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.cc b/chrome/browser/android/offline_pages/prerendering_offliner.cc
index d3267a43069448db5a413e13359bc90f7ac86563..4b68848485fdebda9a000ab24541b29204d4835e 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.cc
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.cc
@@ -184,16 +184,17 @@ bool PrerenderingOffliner::LoadAndSave(
const CompletionCallback& completion_callback,
const ProgressCallback& progress_callback) {
DCHECK(!pending_request_.get());
+ DCHECK(offline_page_model_);
if (pending_request_) {
DVLOG(1) << "Already have pending request";
return false;
}
- // Do not allow loading for custom tabs clients if 3rd party cookies blocked.
- // TODO(dewittj): Revise api to specify policy rather than hard code to
- // name_space.
- if (request.client_id().name_space == kCCTNamespace &&
+ ClientPolicyController* policy_controller =
+ offline_page_model_->GetPolicyController();
+ if (policy_controller->IsDisabledWhenPrefetchDisabled(
+ request.client_id().name_space) &&
(AreThirdPartyCookiesBlocked(browser_context_) ||
IsNetworkPredictionDisabled(browser_context_))) {
DVLOG(1) << "WARNING: Unable to load when 3rd party cookies blocked or "

Powered by Google App Engine
This is Rietveld 408576698