Provide a method to remove inserted style sheet

third_party/WebKit/Source/core/dom/StyleEngine.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
@@ skipping 13 matching lines @@
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #ifndef StyleEngine_h
 #define StyleEngine_h
 
 #include <memory>
+#include <utility>
 #include "core/CoreExport.h"
 #include "core/css/ActiveStyleSheets.h"
 #include "core/css/CSSFontSelectorClient.h"
 #include "core/css/CSSGlobalRuleSet.h"
 #include "core/css/invalidation/StyleInvalidator.h"
 #include "core/css/resolver/StyleResolver.h"
 #include "core/css/resolver/StyleResolverStats.h"
 #include "core/dom/Document.h"
 #include "core/dom/DocumentOrderedList.h"
 #include "core/dom/DocumentStyleSheetCollection.h"
@@ skipping 42 matching lines @@
 
   static StyleEngine* Create(Document& document) {
     return new StyleEngine(document);
   }
 
   ~StyleEngine();
 
   const HeapVector<TraceWrapperMember<StyleSheet>>&
   StyleSheetsForStyleSheetList(TreeScope&);
 
-  const HeapVector<TraceWrapperMember<CSSStyleSheet>>&
+  const HeapVector<std::pair<unsigned, TraceWrapperMember<CSSStyleSheet>>>&
   InjectedAuthorStyleSheets() const {
     return injected_author_style_sheets_;
   }
   CSSStyleSheet* InspectorStyleSheet() const { return inspector_style_sheet_; }
 
   const ActiveStyleSheetVector ActiveStyleSheetsForInspector();
 
   bool NeedsActiveStyleUpdate() const;
   void SetNeedsActiveStyleUpdate(TreeScope&);
   void AddStyleSheetCandidateNode(Node&);
   void RemoveStyleSheetCandidateNode(Node&, ContainerNode& insertion_point);
   void ModifiedStyleSheetCandidateNode(Node&);
   void MediaQueriesChangedInScope(TreeScope&);
   void WatchedSelectorsChanged();
   void InitialViewportChanged();
   void ViewportRulesChanged();
   void HtmlImportAddedOrRemoved();
 
-  void InjectAuthorSheet(StyleSheetContents* author_sheet);
+  unsigned InjectAuthorSheet(StyleSheetContents* author_sheet);

[rune, 2017/05/18 13:13:21]

I think I would've used an stylesheet id type in this api as well.

[limasdf, 2017/05/18 14:32:26]

Done.

+  void RemoveInjectedAuthorSheet(unsigned author_sheet_id);
   CSSStyleSheet& EnsureInspectorStyleSheet();
   RuleSet* WatchedSelectorsRuleSet() {
     return global_rule_set_.WatchedSelectorsRuleSet();
   }
 
   RuleSet* RuleSetForSheet(CSSStyleSheet&);
   void MediaQueryAffectingValueChanged();
   void UpdateStyleSheetsInImport(StyleEngine& master_engine,
                                  DocumentStyleSheetCollector& parent_collector);
   void UpdateActiveStyle();
@@ skipping 211 matching lines @@
   bool is_master_;
 
   // Track the number of currently loading top-level stylesheets needed for
   // layout.  Sheets loaded using the @import directive are not included in this
   // count.  We use this count of pending sheets to detect when we can begin
   // attaching elements and when it is safe to execute scripts.
   int pending_script_blocking_stylesheets_ = 0;
   int pending_render_blocking_stylesheets_ = 0;
   int pending_body_stylesheets_ = 0;
 
-  HeapVector<TraceWrapperMember<CSSStyleSheet>> injected_author_style_sheets_;
+  HeapVector<std::pair<unsigned, TraceWrapperMember<CSSStyleSheet>>>
+      injected_author_style_sheets_;
   Member<CSSStyleSheet> inspector_style_sheet_;
 
   TraceWrapperMember<DocumentStyleSheetCollection>
       document_style_sheet_collection_;
 
   Member<StyleRuleUsageTracker> tracker_;
 
   using StyleSheetCollectionMap =
       HeapHashMap<WeakMember<TreeScope>,
                   Member<ShadowTreeStyleSheetCollection>>;
@@ skipping 22 matching lines @@
   Member<CSSFontSelector> font_selector_;
 
   HeapHashMap<AtomicString, WeakMember<StyleSheetContents>>
       text_to_sheet_cache_;
   HeapHashMap<WeakMember<StyleSheetContents>, AtomicString>
       sheet_to_text_cache_;
 
   std::unique_ptr<StyleResolverStats> style_resolver_stats_;
   unsigned style_for_element_count_ = 0;
 
+  unsigned injected_author_sheets_id_count_ = 0;
+
   friend class StyleEngineTest;
 };
 
 }  // namespace blink
 
 #endif