Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: media/formats/mp4/track_run_iterator.cc

Issue 2835163004: Fix audio keyframe comment in MSE MP4 parser (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp4/track_run_iterator.cc
diff --git a/media/formats/mp4/track_run_iterator.cc b/media/formats/mp4/track_run_iterator.cc
index 25fc5ec5c7867409eff65f88bf5d68929caee9b8..f109873b27a19251a5b9d2f4424fb26e31e7f912 100644
--- a/media/formats/mp4/track_run_iterator.cc
+++ b/media/formats/mp4/track_run_iterator.cc
@@ -169,11 +169,11 @@ static bool PopulateSampleInfo(const TrackExtends& trex,
// that marks non-key video frames as sync samples (http://crbug.com/507916
// and http://crbug.com/310712). Hence, for video we additionally check that
// the sample does not depend on others (FFmpeg does too, see mov_read_trun).
- // Sample dependency is not ignored for audio because encoded audio samples
- // can depend on other samples and still be used for random access. Generally
- // all audio samples are expected to be sync samples, but we prefer to check
- // the flags to catch badly muxed audio (for now anyway ;P). History of
- // attempts to get this right discussed in http://crrev.com/1319813002
+ // Sample dependency is ignored for audio because encoded audio samples can
+ // depend on other samples and still be used for random access. Generally all
+ // audio samples are expected to be sync samples, but we prefer to check the
+ // flags to catch badly muxed audio (for now anyway ;P). History of attempts
+ // to get this right discussed in http://crrev.com/1319813002
bool sample_is_sync_sample = !(flags & kSampleIsNonSyncSample);
bool sample_depends_on_others = sample_depends_on == kSampleDependsOnOthers;
sample_info->is_keyframe = sample_is_sync_sample &&
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698