Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: content/child/web_url_loader_impl_unittest.cc

Issue 2835123005: Send the decoded size when response completed and stop summing in ResourceLoader::DidReceiveData() (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/child/web_url_loader_impl.cc ('k') | content/common/resource_messages.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/web_url_loader_impl.h" 5 #include "content/child/web_url_loader_impl.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 #include <string.h> 8 #include <string.h>
9 9
10 #include <utility> 10 #include <utility>
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 EXPECT_EQ("", error_.domain.Utf8()); 186 EXPECT_EQ("", error_.domain.Utf8());
187 187
188 received_data_.append(data, dataLength); 188 received_data_.append(data, dataLength);
189 189
190 if (delete_on_receive_data_) 190 if (delete_on_receive_data_)
191 loader_.reset(); 191 loader_.reset();
192 } 192 }
193 193
194 void DidFinishLoading(double finishTime, 194 void DidFinishLoading(double finishTime,
195 int64_t totalEncodedDataLength, 195 int64_t totalEncodedDataLength,
196 int64_t totalEncodedBodyLength) override { 196 int64_t totalEncodedBodyLength,
197 int64_t totalDecodedBodyLength) override {
197 EXPECT_TRUE(loader_); 198 EXPECT_TRUE(loader_);
198 EXPECT_TRUE(did_receive_response_); 199 EXPECT_TRUE(did_receive_response_);
199 EXPECT_FALSE(did_finish_); 200 EXPECT_FALSE(did_finish_);
200 did_finish_ = true; 201 did_finish_ = true;
201 202
202 if (delete_on_finish_) 203 if (delete_on_finish_)
203 loader_.reset(); 204 loader_.reset();
204 } 205 }
205 206
206 void DidFail(const blink::WebURLError& error, 207 void DidFail(const blink::WebURLError& error,
207 int64_t totalEncodedDataLength, 208 int64_t totalEncodedDataLength,
208 int64_t totalEncodedBodyLength) override { 209 int64_t totalEncodedBodyLength,
210 int64_t totalDecodedBodyLength) override {
209 EXPECT_TRUE(loader_); 211 EXPECT_TRUE(loader_);
210 EXPECT_FALSE(did_finish_); 212 EXPECT_FALSE(did_finish_);
211 error_ = error; 213 error_ = error;
212 214
213 if (delete_on_fail_) 215 if (delete_on_fail_)
214 loader_.reset(); 216 loader_.reset();
215 } 217 }
216 218
217 WebURLLoaderImpl* loader() { return loader_.get(); } 219 WebURLLoaderImpl* loader() { return loader_.get(); }
218 void DeleteLoader() { 220 void DeleteLoader() {
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 EXPECT_EQ("", client()->received_data()); 318 EXPECT_EQ("", client()->received_data());
317 auto size = strlen(kTestData); 319 auto size = strlen(kTestData);
318 peer()->OnReceivedData( 320 peer()->OnReceivedData(
319 base::MakeUnique<FixedReceivedData>(kTestData, size)); 321 base::MakeUnique<FixedReceivedData>(kTestData, size));
320 EXPECT_EQ(kTestData, client()->received_data()); 322 EXPECT_EQ(kTestData, client()->received_data());
321 } 323 }
322 324
323 void DoCompleteRequest() { 325 void DoCompleteRequest() {
324 EXPECT_FALSE(client()->did_finish()); 326 EXPECT_FALSE(client()->did_finish());
325 peer()->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), 327 peer()->OnCompletedRequest(net::OK, false, false, base::TimeTicks(),
326 strlen(kTestData), strlen(kTestData)); 328 strlen(kTestData), strlen(kTestData),
329 strlen(kTestData));
327 EXPECT_TRUE(client()->did_finish()); 330 EXPECT_TRUE(client()->did_finish());
328 // There should be no error. 331 // There should be no error.
329 EXPECT_EQ(net::OK, client()->error().reason); 332 EXPECT_EQ(net::OK, client()->error().reason);
330 EXPECT_EQ("", client()->error().domain.Utf8()); 333 EXPECT_EQ("", client()->error().domain.Utf8());
331 } 334 }
332 335
333 void DoFailRequest() { 336 void DoFailRequest() {
334 EXPECT_FALSE(client()->did_finish()); 337 EXPECT_FALSE(client()->did_finish());
335 peer()->OnCompletedRequest(net::ERR_FAILED, false, false, base::TimeTicks(), 338 peer()->OnCompletedRequest(net::ERR_FAILED, false, false, base::TimeTicks(),
336 strlen(kTestData), strlen(kTestData)); 339 strlen(kTestData), strlen(kTestData),
340 strlen(kTestData));
337 EXPECT_FALSE(client()->did_finish()); 341 EXPECT_FALSE(client()->did_finish());
338 EXPECT_EQ(net::ERR_FAILED, client()->error().reason); 342 EXPECT_EQ(net::ERR_FAILED, client()->error().reason);
339 EXPECT_EQ(net::kErrorDomain, client()->error().domain.Utf8()); 343 EXPECT_EQ(net::kErrorDomain, client()->error().domain.Utf8());
340 } 344 }
341 345
342 void DoReceiveResponseFtp() { 346 void DoReceiveResponseFtp() {
343 EXPECT_FALSE(client()->did_receive_response()); 347 EXPECT_FALSE(client()->did_receive_response());
344 content::ResourceResponseInfo response_info; 348 content::ResourceResponseInfo response_info;
345 response_info.mime_type = kFtpDirMimeType; 349 response_info.mime_type = kFtpDirMimeType;
346 peer()->OnReceivedResponse(response_info); 350 peer()->OnReceivedResponse(response_info);
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
566 570
567 TEST_F(WebURLLoaderImplTest, FtpDeleteOnReceiveMoreData) { 571 TEST_F(WebURLLoaderImplTest, FtpDeleteOnReceiveMoreData) {
568 DoStartAsyncRequest(); 572 DoStartAsyncRequest();
569 DoReceiveResponseFtp(); 573 DoReceiveResponseFtp();
570 DoReceiveDataFtp(); 574 DoReceiveDataFtp();
571 575
572 // Directory listings are only parsed once the request completes, so this will 576 // Directory listings are only parsed once the request completes, so this will
573 // cancel in DoReceiveDataFtp, before the request finishes. 577 // cancel in DoReceiveDataFtp, before the request finishes.
574 client()->set_delete_on_receive_data(); 578 client()->set_delete_on_receive_data();
575 peer()->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), 579 peer()->OnCompletedRequest(net::OK, false, false, base::TimeTicks(),
576 strlen(kTestData), strlen(kTestData)); 580 strlen(kTestData), strlen(kTestData),
581 strlen(kTestData));
577 EXPECT_FALSE(client()->did_finish()); 582 EXPECT_FALSE(client()->did_finish());
578 } 583 }
579 584
580 TEST_F(WebURLLoaderImplTest, FtpDeleteOnFinish) { 585 TEST_F(WebURLLoaderImplTest, FtpDeleteOnFinish) {
581 client()->set_delete_on_finish(); 586 client()->set_delete_on_finish();
582 DoStartAsyncRequest(); 587 DoStartAsyncRequest();
583 DoReceiveResponseFtp(); 588 DoReceiveResponseFtp();
584 DoReceiveDataFtp(); 589 DoReceiveDataFtp();
585 DoCompleteRequest(); 590 DoCompleteRequest();
586 } 591 }
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
687 int64_t encoded_body_length = 0; 692 int64_t encoded_body_length = 0;
688 client()->loader()->LoadSynchronously( 693 client()->loader()->LoadSynchronously(
689 request, response, error, data, encoded_data_length, encoded_body_length); 694 request, response, error, data, encoded_data_length, encoded_body_length);
690 695
691 EXPECT_EQ(kEncodedBodyLength, encoded_body_length); 696 EXPECT_EQ(kEncodedBodyLength, encoded_body_length);
692 EXPECT_EQ(kEncodedDataLength, encoded_data_length); 697 EXPECT_EQ(kEncodedDataLength, encoded_data_length);
693 } 698 }
694 699
695 } // namespace 700 } // namespace
696 } // namespace content 701 } // namespace content
OLDNEW
« no previous file with comments | « content/child/web_url_loader_impl.cc ('k') | content/common/resource_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698