Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2835123004: Add AnalysisDriver.getLibraryByUri(). (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add AnalysisDriver.getLibraryByUri(). We need this for DDC, and it actually uses it only for SDK - both in cases when DDC compiles SDK (so it needs to analyze SDK libraries), and in when DDC compiles something other than SDK (so it resynthesizes SDK classes from the provided external summary store). In all cases DDC needs these SDK libraries to build TypeProvider and do some HTML magic. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/93f4f5eab77bd967278295060f85e25b3bb97cce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -22 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 4 chunks +32 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/library_context.dart View 3 chunks +30 lines, -10 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-24 18:00:51 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-24 18:09:08 UTC) #2
scheglov
3 years, 8 months ago (2017-04-24 18:41:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
93f4f5eab77bd967278295060f85e25b3bb97cce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698