mash: Use ChromeLauncherControllerImpl, remove Mus subclass stub.

chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_IMPL_H_
 #define CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_IMPL_H_
 
 #include <list>
 #include <memory>
 
@@ skipping 86 matching lines @@
   BrowserShortcutLauncherItemController*
   GetBrowserShortcutLauncherItemController() override;
   bool ShelfBoundsChangesProbablyWithUser(
       ash::WmShelf* shelf,
       const AccountId& account_id) const override;
   void OnUserProfileReadyToSwitch(Profile* profile) override;
   ArcAppDeferredLauncherController* GetArcDeferredLauncher() override;
   const std::string& GetLaunchIDForShelfID(ash::ShelfID id) override;
   void AttachProfile(Profile* profile_to_attach) override;
 
+  ash::ShelfModel* shelf_model() const { return model_; }

[James Cook, 2017/04/26 01:03:26]

Why not provide a GetShelfModel() on ChromeLauncherController instead? Then
there would be the possibility of returning a fake/stub one in unit tests.

It feels kinda of weird to have a relatively nice abstract base class (CLC) then
tie all the other classes to the concrete CLCImpl.

Is your long-term plan to collapse CLC and CLCImpl? Am I missing something?

[msw, 2017/04/26 01:35:14]

Yes, I plan to merge CLC and CLCImpl in an imminent followup CL. I thought this
might be easier, otherwise I'd have to go back and switch GetShelfModel() to
shelf_model() at all these call sites anyway.

+
   // Access to the BrowserStatusMonitor for tests.
   BrowserStatusMonitor* browser_status_monitor_for_test() {
     return browser_status_monitor_.get();
   }
 
   // Access to the AppWindowLauncherController list for tests.
   const std::vector<std::unique_ptr<AppWindowLauncherController>>&
   app_window_controllers_for_test() {
     return app_window_controllers_;
   }
@@ skipping 158 matching lines @@
   typedef std::vector<std::string> RunningAppListIds;
   typedef std::map<std::string, RunningAppListIds> RunningAppListIdMap;
   RunningAppListIdMap last_used_running_application_order_;
 
   base::WeakPtrFactory<ChromeLauncherControllerImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeLauncherControllerImpl);
 };
 
 #endif  // CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_IMPL_H_