Add stopgap for angular autocompletion.

Add stopgap for angular autocompletion.


Autocompletion for angular

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/a211c5e4e7b466c3dc1faa66d0ba29d1b04ff496

[maxkim, 2017-04-26 15:24:50]

Description was changed from

==========
Add stopgap for angular autocompletion.


Autocompletion for angular

BUG=
==========

to

==========
Add stopgap for angular autocompletion.


Autocompletion for angular

BUG=
==========

[maxkim, 2017-04-26 15:24:50]

maxkim@google.com changed reviewers:
+ brianwilkerson@google.com, konstantin.scheglov@gmail.com,
mfairhurst@google.com

[Brian Wilkerson, 2017-04-26 19:30:31]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com
- konstantin.scheglov@gmail.com

[Brian Wilkerson, 2017-04-26 19:30:32]

I don't understand why the two files are listed under "sdk/pkg", but the actual
changes lgtm.

[scheglov, 2017-04-26 19:35:04]

lgtm

https://codereview.chromium.org/2835053005/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/domain_completion.dart (right):

https://codereview.chromium.org/2835053005/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/domain_completion.dart:143: await
server.onNoAnalysisCompletion(request, this, params, performance,
completionId,);
Extra comma at the end?

[maxkim, 2017-04-26 20:14:58]

On 2017/04/26 19:30:32, Brian Wilkerson wrote:
> I don't understand why the two files are listed under "sdk/pkg", but the
actual
> changes lgtm.

I'm not sure either; it automatically pushed those files too when I did upload
cl.

[maxkim, 2017-04-26 20:21:21]

On 2017/04/26 20:14:58, maxkim wrote:
> On 2017/04/26 19:30:32, Brian Wilkerson wrote:
> > I don't understand why the two files are listed under "sdk/pkg", but the
> actual
> > changes lgtm.
> 
> I'm not sure either; it automatically pushed those files too when I did upload
> cl.

I'll try and fix this issue as well as the extra comma.

[Brian Wilkerson, 2017-04-26 20:57:01]

still lgtm

[maxkim, 2017-04-26 22:48:24]

Description was changed from

==========
Add stopgap for angular autocompletion.


Autocompletion for angular

BUG=
==========

to

==========
Add stopgap for angular autocompletion.


Autocompletion for angular

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a211c5e4e7b466c3dc1faa66d0ba29d1b04ff496
==========

[maxkim, 2017-04-26 22:48:28]

Committed patchset #2 (id:20001) manually as
a211c5e4e7b466c3dc1faa66d0ba29d1b04ff496 (presubmit successful).

[maxkim, 2017-05-24 19:15:28]

Patchset #3 (id:40001) has been deleted