Issue 2835043: Revert 52721 - Refactor the implementation of InputWindowDialog....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2835043: Revert 52721 - Refactor the implementation of InputWindowDialog.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by tfarina

Modified:
4 years ago

Reviewers:
tfarina

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 52721 - Refactor the implementation of InputWindowDialog. - Move the implementation of each platform under its respective source directory. - Rename the classes to match with pattern used in the chrome source. - In the gtk side, use the gtk signal macros for the callback events. BUG=None TEST=open the bookmark editor dialog, everything should works as before on windows and linux. Review URL: http://codereview.chromium.org/2832028 TBR=tfarina@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52727

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -404 lines)			Patch
D	chrome/browser/gtk/input_window_dialog_gtk.h	View	1 chunk	+0 lines, -49 lines	0 comments	Download
D	chrome/browser/gtk/input_window_dialog_gtk.cc	View	1 chunk	+0 lines, -113 lines	0 comments	Download
A +	chrome/browser/input_window_dialog_gtk.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/input_window_dialog_win.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/browser/views/input_window_dialog_win.h	View	1 chunk	+0 lines, -105 lines	0 comments	Download
D	chrome/browser/views/input_window_dialog_win.cc	View	1 chunk	+0 lines, -135 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	3 chunks	+2 lines, -4 lines	0 comments	Download

Trybot results:

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages