Chromium Code Reviews
Help | Chromium Project | Sign in
(25)

Issue 2835036: Mac: Add tooltip to download item. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by Nico
Modified:
4 years ago
CC:
chromium-reviews, John Grabowski, Paul Godavari, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Mac: Add tooltip to download item. BUG=41195 TEST=Download file with long name. Dangerous download view shouldn't have tooltip, normal download button should. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51680

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 11

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M chrome/browser/cocoa/download_item_controller.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/cocoa/download_item_controller.mm View 1 2 3 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/download_item_mac.mm View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
Commit: CQ not working?

Messages

Total messages: 5 (0 generated)
Nico
4 years, 10 months ago (2010-07-06 23:49:39 UTC) #1
viettrungluu
http://codereview.chromium.org/2835036/diff/4001/5001 File chrome/browser/cocoa/download_item_controller.h (right): http://codereview.chromium.org/2835036/diff/4001/5001#newcode1 chrome/browser/cocoa/download_item_controller.h:1: // Copyright (c) 2009 The Chromium Authors. All rights ...
4 years, 10 months ago (2010-07-07 00:09:54 UTC) #2
Nico
Consider sending "LG" with your comments if you have only nits. http://codereview.chromium.org/2835036/diff/4001/5001 File chrome/browser/cocoa/download_item_controller.h (right): ...
4 years, 10 months ago (2010-07-07 00:17:18 UTC) #3
Nico
http://codereview.chromium.org/2835036/diff/4001/5003 File chrome/browser/cocoa/download_item_mac.mm (right): http://codereview.chromium.org/2835036/diff/4001/5003#newcode1 chrome/browser/cocoa/download_item_mac.mm:1: // Copyright (c) 2009 The Chromium Authors. All rights ...
4 years, 10 months ago (2010-07-07 00:17:33 UTC) #4
viettrungluu
4 years, 10 months ago (2010-07-07 02:32:03 UTC) #5
On 2010/07/07 00:17:18, Nico wrote:
> Consider sending "LG" with your comments if you have only nits.

Wait for the LG, despite the oversight. Else I'm disinclined to review.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be