Rename GeolocationExceptionsView, make it more reusable.

Rename GeolocationExceptionsView, make it more reusable.

Specifically,
geolocation_exceptions_window_controller => simple_content_exceptions_window_controller (mac)
geolocation_exceptions_view => simple_content_exceptions_view (win)
geolocation_content_exceptions_window => simple_content_exceptions_window (linux)

It's now easy to use it to show desktop notification exceptions as well.

No functionality change.

BUG=45547
TEST=geolocation exceptions dialog still works

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51392

[bulach, 2010-07-01 18:18:51]

LGTM

few minor comments below, specially about the ownership transferring in the
factory methods for win/linux:

http://codereview.chromium.org/2835031/diff/6001/4010
File chrome/browser/cocoa/simple_content_exceptions_window_controller.h (right):

http://codereview.chromium.org/2835031/diff/6001/4010#newcode31
chrome/browser/cocoa/simple_content_exceptions_window_controller.h:31: +
(id)controllerWithTableModel:(RemoveRowsTableModel*)model;
not sure about the rules, but either controllerWithModel or
controllerWithRemoveRowsTableModel?

http://codereview.chromium.org/2835031/diff/6001/4011
File chrome/browser/cocoa/simple_content_exceptions_window_controller.mm
(right):

http://codereview.chromium.org/2835031/diff/6001/4011#newcode66
chrome/browser/cocoa/simple_content_exceptions_window_controller.mm:66: -
(id)initWithTableModel:(RemoveRowsTableModel*)model {
ditto

http://codereview.chromium.org/2835031/diff/8001/9007
File chrome/browser/gtk/options/simple_content_exceptions_window.cc (right):

http://codereview.chromium.org/2835031/diff/8001/9007#newcode25
chrome/browser/gtk/options/simple_content_exceptions_window.cc:25:
DCHECK(model);
scoped_ptr<RemoveRowsTableModel> owned_model(model);

http://codereview.chromium.org/2835031/diff/8001/9007#newcode28
chrome/browser/gtk/options/simple_content_exceptions_window.cc:28: instance =
new SimpleContentExceptionsWindow(parent, model);
owned_model.release()

http://codereview.chromium.org/2835031/diff/8001/9007#newcode30
chrome/browser/gtk/options/simple_content_exceptions_window.cc:30:
gtk_util::PresentWindow(instance->dialog_, 0);
...or delete model here.

http://codereview.chromium.org/2835031/diff/8001/9010
File chrome/browser/views/options/simple_content_exceptions_view.cc (right):

http://codereview.chromium.org/2835031/diff/8001/9010#newcode28
chrome/browser/views/options/simple_content_exceptions_view.cc:28: instance =
new SimpleContentExceptionsView(model);
as above, we need to delete model if not transferring ownership to
SimpleContentExceptionsView

[Nico, 2010-07-01 18:25:01]

Thanks!

http://codereview.chromium.org/2835031/diff/6001/4010
File chrome/browser/cocoa/simple_content_exceptions_window_controller.h (right):

http://codereview.chromium.org/2835031/diff/6001/4010#newcode31
chrome/browser/cocoa/simple_content_exceptions_window_controller.h:31: +
(id)controllerWithTableModel:(RemoveRowsTableModel*)model;
On 2010/07/01 18:18:52, bulach wrote:
> not sure about the rules, but either controllerWithModel or
> controllerWithRemoveRowsTableModel?

I had controllerWithModel first, but that sounded to general.
controllerWithRemoveRowsTableModel sounds too wordy imho. I'd keep the current
name.

http://codereview.chromium.org/2835031/diff/8001/9007
File chrome/browser/gtk/options/simple_content_exceptions_window.cc (right):

http://codereview.chromium.org/2835031/diff/8001/9007#newcode25
chrome/browser/gtk/options/simple_content_exceptions_window.cc:25:
DCHECK(model);
On 2010/07/01 18:18:52, bulach wrote:
> scoped_ptr<RemoveRowsTableModel> owned_model(model);

Ooh, good catch! Done.