Chromium Code Reviews
Help | Chromium Project | Sign in
(111)

Issue 2835014: Make the apply.js unit test more resilient to differing stack positions.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by zarko
Modified:
2 years, 11 months ago
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Make the apply.js unit test more resilient to differing stack positions.

More information is at http://code.google.com/p/v8/issues/detail?id=742


Committed: http://code.google.com/p/v8/source/detail?r=4918

Patch Set 1 #

Total comments: 1

Patch Set 2 : enable test in .status; use booleans in test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Lint Patch
M test/mjsunit/apply.js View 1 2 chunks +14 lines, -1 line 0 comments 0 errors Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 2 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 5
zarko
I think this change should fix the problem with this test on OS X. (The ...
3 years, 10 months ago #1
Erik Corry
LGTM
3 years, 10 months ago #2
Vitaly Repeshko
LGTM test/mjsunit/mjsunit.status should be updated to enable the test. http://codereview.chromium.org/2835014/diff/1/2 File test/mjsunit/apply.js (right): http://codereview.chromium.org/2835014/diff/1/2#newcode115 test/mjsunit/apply.js:115: ...
3 years, 10 months ago #3
zarko
Just want to make sure that I'm doing this correctly. Thanks Luke http://codereview.chromium.org/2835014/diff/5001/6002 File test/mjsunit/mjsunit.status ...
3 years, 10 months ago #4
Vitaly Repeshko
3 years, 10 months ago #5
http://codereview.chromium.org/2835014/diff/5001/6002
File test/mjsunit/mjsunit.status (left):

http://codereview.chromium.org/2835014/diff/5001/6002#oldcode39
test/mjsunit/mjsunit.status:39: 
On 2010/06/22 21:48:20, zarko wrote:
> Is this sufficient to re-enable the test?

I think so, yes. After submitting you can check status at
http://build.chromium.org/buildbot/v8/waterfall. Please also update the bugs.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6