Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 2835014: Make the apply.js unit test more resilient to differing stack positions.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
7 years ago by zarko
6 years, 1 month ago


Make the apply.js unit test more resilient to differing stack positions. More information is at Committed:

Patch Set 1 #

Total comments: 1

Patch Set 2 : enable test in .status; use booleans in test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M test/mjsunit/apply.js View 1 2 chunks +14 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 2 comments Download
Trybot results:
Commit queue not available (can’t edit this change).


Total messages: 5 (0 generated)
I think this change should fix the problem with this test on OS X. (The ...
7 years ago (2010-06-21 23:51:10 UTC) #1
Erik Corry
7 years ago (2010-06-22 10:21:38 UTC) #2
Vitaly Repeshko
LGTM test/mjsunit/mjsunit.status should be updated to enable the test. File test/mjsunit/apply.js (right): test/mjsunit/apply.js:115: ...
7 years ago (2010-06-22 12:58:32 UTC) #3
Just want to make sure that I'm doing this correctly. Thanks Luke File test/mjsunit/mjsunit.status ...
7 years ago (2010-06-22 21:48:20 UTC) #4
Vitaly Repeshko
7 years ago (2010-06-22 22:01:46 UTC) #5
File test/mjsunit/mjsunit.status (left):
On 2010/06/22 21:48:20, zarko wrote:
> Is this sufficient to re-enable the test?

I think so, yes. After submitting you can check status at Please also update the bugs.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318