Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2834993002: Add support for three more plugin requests (Closed)

Created:
3 years, 8 months ago by Brian Wilkerson
Modified:
3 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/domain_analysis.dart View 4 chunks +28 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/plugin_manager.dart View 5 chunks +98 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/request_converter.dart View 1 chunk +33 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/set_priority_files_test.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/update_content_test.dart View 2 chunks +50 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 3 chunks +22 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 2 chunks +18 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/request_converter_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 8 months ago (2017-04-22 15:46:00 UTC) #2
scheglov
LGTM
3 years, 8 months ago (2017-04-22 15:53:19 UTC) #3
Brian Wilkerson
3 years, 8 months ago (2017-04-22 16:02:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5695e95902491759008ffc76cf7327b45901638f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698