Add special completion for control-flow block exits

Add special completion for control-flow block exits

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/00d04dda08cdd1a662ac54eb5cd6b83440fe40ae

[messick, 2017-04-21 21:33:02]

messick@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[messick, 2017-04-21 21:33:03]

The basic pattern is the code adds a semicolon to a return or throw statement
then inserts a newline plus indent after the block containing the return or
throw.

[Brian Wilkerson, 2017-04-21 21:45:45]

lgtm

https://codereview.chromium.org/2834913002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
(right):

https://codereview.chromium.org/2834913002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart:238:
int _appendNewlinePlusIndentAt(int offset) {
I don't feel strongly about it, but in case you didn't think about it, you could
have a single method by writing:

int _appendNewlinePlusIndent({int offset}) {
  offset ??= selectionOffset;

https://codereview.chromium.org/2834913002/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart
(right):

https://codereview.chromium.org/2834913002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart:240:
}
Would it be useful to have a test like

if (true) return

[messick, 2017-04-21 21:50:47]

Two really good points, thanks.

I'll commit as-is and make those changes in the next CL.

[messick, 2017-04-21 21:51:51]

Description was changed from

==========
Add special completion for control-flow block exits
==========

to

==========
Add special completion for control-flow block exits

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/00d04dda08cdd1a662ac54eb5cd6b83440fe40ae
==========

[messick, 2017-04-21 21:51:52]

Committed patchset #1 (id:1) manually as
00d04dda08cdd1a662ac54eb5cd6b83440fe40ae (presubmit successful).