Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 28349: Make sure the scoped_ptr is set before checking if the file is open. Fixes a ... (Closed)

Created:
11 years, 9 months ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
ananta
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix a crash when installing plugins. * Make sure the scoped_ptr is initialized before trying to open a file. * Assign the result of FilePath::Append to download_file_path_. R=ananta BUG=8087 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10787

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/plugin_process_host.cc View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Hawkins
11 years, 9 months ago (2009-03-03 01:30:16 UTC) #1
James Hawkins
11 years, 9 months ago (2009-03-03 01:37:29 UTC) #2
ananta
LGTM with the following issue fixed. In PluginDownloadUrlHelper::OnResponseStarted Please change download_file_path_.Append(UTF8ToWide(request_url.ExtractFileName())); to download_file_path_ = download_file_path_.Append(UTF8ToWide(request_url.ExtractFileName()));
11 years, 9 months ago (2009-03-03 02:05:22 UTC) #3
James Hawkins
11 years, 9 months ago (2009-03-03 02:05:54 UTC) #4

          

Powered by Google App Engine
This is Rietveld 408576698