Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2834773003: Remove the limited invalidation feature. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the limited invalidation feature. So, we remove IncrementalCompilationUnitElementBuilder, which was one of the places that potentially modifies element models. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e24b9c218dd8033c23add3117f760cc904fbfc79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6558 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 3 chunks +0 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 3 chunks +0 lines, -49 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 4 chunks +0 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +0 lines, -333 lines 0 comments Download
D pkg/analyzer/lib/src/task/incremental_element_builder.dart View 1 chunk +0 lines, -784 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 6 chunks +21 lines, -2351 lines 0 comments Download
D pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 1 chunk +0 lines, -2369 lines 0 comments Download
M pkg/analyzer/test/src/task/test_all.dart View 2 chunks +0 lines, -3 lines 0 comments Download
D pkg/analyzer/test/stress/for_git_repository.dart View 1 chunk +0 lines, -638 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-21 18:56:18 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-21 19:06:34 UTC) #2
scheglov
3 years, 8 months ago (2017-04-21 19:09:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e24b9c218dd8033c23add3117f760cc904fbfc79 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698