Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: components/storage_monitor/storage_monitor_chromeos.cc

Issue 2834703003: Remove unmapped media galleries histograms. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/storage_monitor/storage_monitor_chromeos.cc
diff --git a/components/storage_monitor/storage_monitor_chromeos.cc b/components/storage_monitor/storage_monitor_chromeos.cc
index 228cc4408c2f2aa04b965f46d51c4e57ab128990..edce2a560fd86c451149e766cdc97bc7eb447323 100644
--- a/components/storage_monitor/storage_monitor_chromeos.cc
+++ b/components/storage_monitor/storage_monitor_chromeos.cc
@@ -57,10 +57,6 @@ bool GetDeviceInfo(const DiskMountManager::MountPointInfo& mount_info,
return false;
std::string unique_id = MakeDeviceUniqueId(*disk);
- // Keep track of device uuid and label, to see how often we receive empty
- // values.
- base::string16 device_label = base::UTF8ToUTF16(disk->device_label());
- MediaStorageUtil::RecordDeviceInfoHistogram(true, unique_id, device_label);
if (unique_id.empty())
return false;
@@ -68,12 +64,11 @@ bool GetDeviceInfo(const DiskMountManager::MountPointInfo& mount_info,
StorageInfo::REMOVABLE_MASS_STORAGE_WITH_DCIM :
StorageInfo::REMOVABLE_MASS_STORAGE_NO_DCIM;
- *info = StorageInfo(StorageInfo::MakeDeviceId(type, unique_id),
- mount_info.mount_path,
- device_label,
- base::UTF8ToUTF16(disk->vendor_name()),
- base::UTF8ToUTF16(disk->product_name()),
- disk->total_size_in_bytes());
+ *info = StorageInfo(
+ StorageInfo::MakeDeviceId(type, unique_id), mount_info.mount_path,
+ base::UTF8ToUTF16(disk->device_label()),
+ base::UTF8ToUTF16(disk->vendor_name()),
+ base::UTF8ToUTF16(disk->product_name()), disk->total_size_in_bytes());
return true;
}
« no previous file with comments | « components/storage_monitor/portable_device_watcher_win.cc ('k') | components/storage_monitor/storage_monitor_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698