Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2834673002: Revert "Update PluginWatcher to be more efficient" (TBR) (Closed)

Created:
3 years, 8 months ago by Brian Wilkerson
Modified:
3 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Update PluginWatcher to be more efficient" Committed: https://github.com/dart-lang/sdk/commit/f8e18d0888a3cddf10e1d76af0863ee971d76239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M pkg/analysis_server/lib/src/plugin/plugin_watcher.dart View 3 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
This caused some tests to fail and I don't know how long it will take ...
3 years, 8 months ago (2017-04-20 17:52:53 UTC) #2
Brian Wilkerson
Committed patchset #1 (id:1) manually as f8e18d0888a3cddf10e1d76af0863ee971d76239 (presubmit successful).
3 years, 8 months ago (2017-04-20 17:53:07 UTC) #4
scheglov
3 years, 8 months ago (2017-04-20 18:02:52 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698