Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2834663002: Fix ddc perf issue (Closed)

Created:
3 years, 8 months ago by vsm
Modified:
3 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix ddc perf issue This brings compilation time on large_class_declaration_test down from 30s to 4s. Just analysis is about 3.2s. (All #s without snapshotted tools.) Fixes #29234 R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/b98729503cfa65360e9441bab10e9c981ac135ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M pkg/dev_compiler/lib/src/compiler/js_names.dart View 4 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 8 months ago (2017-04-20 17:09:40 UTC) #3
Jennifer Messerly
LGTM^2
3 years, 8 months ago (2017-04-20 18:15:57 UTC) #4
vsm
3 years, 8 months ago (2017-04-20 18:24:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b98729503cfa65360e9441bab10e9c981ac135ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698