Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 283463003: cc: Fix tile manager raster tile iterator perftest. (Closed)

Created:
6 years, 7 months ago by vmpstr
Modified:
6 years, 7 months ago
Reviewers:
reveman, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Fix tile manager raster tile iterator perftest. This test is currently broken, as it doesn't really reset the initial conditions each run. NOTE TO PERF SHERIFFS --------------------- This is very likely to regress all of the tile_manager_raster_tile_iterator tests. This is expected, as the test currently doesn't do anything useful. This is a correctness fix for that test. R=reveman, enne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269885

Patch Set 1 #

Total comments: 2

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M cc/resources/tile_manager_perftest.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vmpstr
Please take a look.
6 years, 7 months ago (2014-05-12 17:27:14 UTC) #1
enne (OOO)
lgtm
6 years, 7 months ago (2014-05-12 18:33:28 UTC) #2
enne (OOO)
https://codereview.chromium.org/283463003/diff/1/cc/resources/tile_manager_perftest.cc File cc/resources/tile_manager_perftest.cc (right): https://codereview.chromium.org/283463003/diff/1/cc/resources/tile_manager_perftest.cc#newcode305 cc/resources/tile_manager_perftest.cc:305: unsigned count = tile_count; style nit: unsigned => int
6 years, 7 months ago (2014-05-12 18:33:33 UTC) #3
vmpstr
https://codereview.chromium.org/283463003/diff/1/cc/resources/tile_manager_perftest.cc File cc/resources/tile_manager_perftest.cc (right): https://codereview.chromium.org/283463003/diff/1/cc/resources/tile_manager_perftest.cc#newcode305 cc/resources/tile_manager_perftest.cc:305: unsigned count = tile_count; On 2014/05/12 18:33:33, enne wrote: ...
6 years, 7 months ago (2014-05-12 18:39:15 UTC) #4
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 7 months ago (2014-05-12 18:39:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/283463003/20001
6 years, 7 months ago (2014-05-12 18:39:44 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 21:48:42 UTC) #7
Message was sent while issue was closed.
Change committed as 269885

Powered by Google App Engine
This is Rietveld 408576698