Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4070)

Unified Diff: chrome/browser/safe_browsing/srt_chrome_prompt_impl.h

Issue 2834613003: Adds error handling support for the SwReporter launcher. (Closed)
Patch Set: Code review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/srt_chrome_prompt_impl.h
diff --git a/chrome/browser/safe_browsing/srt_chrome_prompt_impl.h b/chrome/browser/safe_browsing/srt_chrome_prompt_impl.h
index bf14b30ff80655a3d21a277e5e7072eeae42b919..94b24d5d4cf5d67fb6f7cfae986230eff5252539 100644
--- a/chrome/browser/safe_browsing/srt_chrome_prompt_impl.h
+++ b/chrome/browser/safe_browsing/srt_chrome_prompt_impl.h
@@ -5,6 +5,7 @@
#ifndef CHROME_BROWSER_SAFE_BROWSING_SRT_CHROME_PROMPT_IMPL_H_
#define CHROME_BROWSER_SAFE_BROWSING_SRT_CHROME_PROMPT_IMPL_H_
+#include "base/macros.h"
#include "components/chrome_cleaner/public/interfaces/chrome_prompt.mojom.h"
#include "mojo/public/cpp/bindings/binding.h"
@@ -13,7 +14,8 @@ namespace safe_browsing {
// Implementation of the ChromePrompt Mojo interface.
class ChromePromptImpl : public chrome_cleaner::mojom::ChromePrompt {
public:
- explicit ChromePromptImpl(chrome_cleaner::mojom::ChromePromptRequest request);
+ explicit ChromePromptImpl(chrome_cleaner::mojom::ChromePromptRequest request,
grt (UTC plus 2) 2017/04/25 07:06:40 remove "explicit" since there are two args now
ftirelo 2017/04/25 22:24:05 Done.
+ base::Closure on_connection_closed);
grt (UTC plus 2) 2017/04/25 07:06:39 #include "base/callback.h"
ftirelo 2017/04/25 22:24:05 Included "base/callback_forward.h" instead that de
grt (UTC plus 2) 2017/04/26 08:46:46 That would be sufficient if the Closure were being
ftirelo 2017/04/26 14:14:15 Done.
~ChromePromptImpl() override;
void PromptUser(
@@ -24,6 +26,8 @@ class ChromePromptImpl : public chrome_cleaner::mojom::ChromePrompt {
private:
mojo::Binding<chrome_cleaner::mojom::ChromePrompt> binding_;
+
+ DISALLOW_COPY_AND_ASSIGN(ChromePromptImpl);
};
} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698