Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: chrome/browser/safe_browsing/srt_fetcher_win.h

Issue 2834613003: Adds error handling support for the SwReporter launcher. (Closed)
Patch Set: Code review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/srt_fetcher_win.h
diff --git a/chrome/browser/safe_browsing/srt_fetcher_win.h b/chrome/browser/safe_browsing/srt_fetcher_win.h
index 2d1ca858de6bbcbdeb014a1d7f3507f3e7f74af9..fe5df99593bcfc1c75c2307475feec7a407fb209 100644
--- a/chrome/browser/safe_browsing/srt_fetcher_win.h
+++ b/chrome/browser/safe_browsing/srt_fetcher_win.h
@@ -16,6 +16,7 @@
#include "base/process/launch.h"
#include "base/process/process.h"
#include "base/time/time.h"
+#include "chrome/browser/safe_browsing/srt_chrome_prompt_impl.h"
namespace base {
class FilePath;
@@ -28,7 +29,7 @@ class Browser;
namespace safe_browsing {
// A special exit code identifying a failure to run the reporter.
-const int kReporterFailureExitCode = INT_MAX;
+const int kReporterNotLaunchedExitCode = INT_MAX;
// The number of days to wait before triggering another reporter run.
const int kDaysBetweenSuccessfulSwReporterRuns = 7;
@@ -122,6 +123,11 @@ class SwReporterTestingDelegate {
// A task runner used to spawn the reporter process (which blocks).
virtual base::TaskRunner* BlockingTaskRunner() const = 0;
+
+ // Returns a ChromePromptImpl object that keeps track of specific actions
+ // during execution.
+ virtual std::unique_ptr<ChromePromptImpl> CreateChromePromptImpl(
+ chrome_cleaner::mojom::ChromePromptRequest request) = 0;
};
// Set a delegate for testing. The implementation will not take ownership of

Powered by Google App Engine
This is Rietveld 408576698