OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2017 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #include "base/test/scoped_feature_list.h" | |
6 | |
7 #include <string> | |
8 #include "base/metrics/field_trial.h" | |
9 #include "testing/gtest/include/gtest/gtest.h" | |
10 | |
11 namespace base { | |
12 namespace test { | |
13 | |
14 namespace { | |
15 | |
16 const base::Feature kTestFeature1{"TestFeature1", | |
17 base::FEATURE_DISABLED_BY_DEFAULT}; | |
18 const base::Feature kTestFeature2{"TestFeature2", | |
19 base::FEATURE_DISABLED_BY_DEFAULT}; | |
20 | |
21 void ExpectFeatures(const std::string& enabled_features, | |
22 const std::string& disabled_features) { | |
23 base::FeatureList* list = base::FeatureList::GetInstance(); | |
24 std::string actual_enabled_features; | |
25 std::string actual_disabled_features; | |
26 | |
27 list->GetFeatureOverrides(&actual_enabled_features, | |
28 &actual_disabled_features); | |
29 | |
30 EXPECT_EQ(enabled_features, actual_enabled_features); | |
31 EXPECT_EQ(disabled_features, actual_disabled_features); | |
32 } | |
33 | |
34 } // namespace | |
35 | |
36 class ScopedFeatureListTest : public testing::Test { | |
37 public: | |
38 ScopedFeatureListTest() { | |
39 // Clear default feature list. | |
40 std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList); | |
41 feature_list->InitializeFromCommandLine(std::string(), std::string()); | |
42 original_feature_list_ = base::FeatureList::ClearInstanceForTesting(); | |
43 base::FeatureList::SetInstance(std::move(feature_list)); | |
44 } | |
45 | |
46 ~ScopedFeatureListTest() override { | |
47 // Restore feature list. | |
48 if (original_feature_list_) { | |
49 base::FeatureList::ClearInstanceForTesting(); | |
50 base::FeatureList::RestoreInstanceForTesting( | |
51 std::move(original_feature_list_)); | |
52 } | |
53 } | |
54 | |
55 private: | |
56 // Save the present FeatureList and restore it after test finish. | |
57 std::unique_ptr<FeatureList> original_feature_list_; | |
Ilya Sherman
2017/04/25 21:41:58
nit: Please leave a blank line between this and DI
| |
58 DISALLOW_COPY_AND_ASSIGN(ScopedFeatureListTest); | |
59 }; | |
60 | |
61 TEST_F(ScopedFeatureListTest, BasicScoped) { | |
62 ExpectFeatures(std::string(), std::string()); | |
63 EXPECT_FALSE(FeatureList::IsEnabled(kTestFeature1)); | |
64 { | |
65 test::ScopedFeatureList feature_list1; | |
66 feature_list1.InitFromCommandLine("TestFeature1", std::string()); | |
67 ExpectFeatures("TestFeature1", std::string()); | |
68 EXPECT_TRUE(FeatureList::IsEnabled(kTestFeature1)); | |
69 } | |
70 ExpectFeatures(std::string(), std::string()); | |
71 EXPECT_FALSE(FeatureList::IsEnabled(kTestFeature1)); | |
72 } | |
73 | |
74 TEST_F(ScopedFeatureListTest, EnableFeatureOverrideDisable) { | |
75 test::ScopedFeatureList feature_list1; | |
76 feature_list1.InitWithFeatures({}, {kTestFeature1}); | |
77 | |
78 { | |
79 test::ScopedFeatureList feature_list2; | |
80 feature_list2.InitWithFeatures({kTestFeature1}, {}); | |
81 ExpectFeatures("TestFeature1", std::string()); | |
82 } | |
83 } | |
84 | |
85 TEST_F(ScopedFeatureListTest, FeatureOverrideNotMakeDuplicate) { | |
86 test::ScopedFeatureList feature_list1; | |
87 feature_list1.InitWithFeatures({}, {kTestFeature1}); | |
88 | |
89 { | |
90 test::ScopedFeatureList feature_list2; | |
91 feature_list2.InitWithFeatures({}, {kTestFeature1}); | |
92 ExpectFeatures(std::string(), "TestFeature1"); | |
93 } | |
94 } | |
95 | |
96 TEST_F(ScopedFeatureListTest, FeatureOverrideFeatureWithDefault) { | |
97 test::ScopedFeatureList feature_list1; | |
98 feature_list1.InitFromCommandLine("*TestFeature1", std::string()); | |
99 | |
100 { | |
101 test::ScopedFeatureList feature_list2; | |
102 feature_list2.InitWithFeatures({kTestFeature1}, {}); | |
103 ExpectFeatures("TestFeature1", std::string()); | |
104 } | |
105 } | |
106 | |
107 TEST_F(ScopedFeatureListTest, FeatureOverrideFeatureWithDefault2) { | |
108 test::ScopedFeatureList feature_list1; | |
109 feature_list1.InitFromCommandLine("*TestFeature1", std::string()); | |
110 | |
111 { | |
112 test::ScopedFeatureList feature_list2; | |
113 feature_list2.InitWithFeatures({}, {kTestFeature1}); | |
114 ExpectFeatures(std::string(), "TestFeature1"); | |
115 } | |
116 } | |
117 | |
118 TEST_F(ScopedFeatureListTest, FeatureOverrideFeatureWithEnabledFieldTried) { | |
119 test::ScopedFeatureList feature_list1; | |
120 | |
121 std::unique_ptr<FeatureList> feature_list(new FeatureList); | |
122 FieldTrialList field_trial_list(nullptr); | |
123 FieldTrial* trial = FieldTrialList::CreateFieldTrial("TrialExample", "A"); | |
124 feature_list->RegisterFieldTrialOverride( | |
125 kTestFeature1.name, FeatureList::OVERRIDE_ENABLE_FEATURE, trial); | |
126 feature_list1.InitWithFeatureList(std::move(feature_list)); | |
127 | |
128 { | |
129 test::ScopedFeatureList feature_list2; | |
130 feature_list2.InitWithFeatures({kTestFeature1}, {}); | |
131 ExpectFeatures("TestFeature1", std::string()); | |
132 } | |
133 } | |
134 | |
135 TEST_F(ScopedFeatureListTest, FeatureOverrideFeatureWithDisabledFieldTried) { | |
136 test::ScopedFeatureList feature_list1; | |
137 | |
138 std::unique_ptr<FeatureList> feature_list(new FeatureList); | |
139 FieldTrialList field_trial_list(nullptr); | |
140 FieldTrial* trial = FieldTrialList::CreateFieldTrial("TrialExample", "A"); | |
141 feature_list->RegisterFieldTrialOverride( | |
142 kTestFeature1.name, FeatureList::OVERRIDE_DISABLE_FEATURE, trial); | |
143 feature_list1.InitWithFeatureList(std::move(feature_list)); | |
144 | |
145 { | |
146 test::ScopedFeatureList feature_list2; | |
147 feature_list2.InitWithFeatures({kTestFeature1}, {}); | |
148 ExpectFeatures("TestFeature1", std::string()); | |
149 } | |
150 } | |
151 | |
152 TEST_F(ScopedFeatureListTest, FeatureOverrideKeepsOtherExistingFeature) { | |
153 test::ScopedFeatureList feature_list1; | |
154 feature_list1.InitWithFeatures({}, {kTestFeature1}); | |
155 | |
156 { | |
157 test::ScopedFeatureList feature_list2; | |
158 feature_list2.InitWithFeatures({}, {kTestFeature2}); | |
159 EXPECT_FALSE(FeatureList::IsEnabled(kTestFeature1)); | |
160 EXPECT_FALSE(FeatureList::IsEnabled(kTestFeature2)); | |
161 } | |
162 } | |
163 | |
164 TEST_F(ScopedFeatureListTest, FeatureOverrideKeepsOtherExistingFeature2) { | |
165 test::ScopedFeatureList feature_list1; | |
166 feature_list1.InitWithFeatures({}, {kTestFeature1}); | |
167 | |
168 { | |
169 test::ScopedFeatureList feature_list2; | |
170 feature_list2.InitWithFeatures({kTestFeature2}, {}); | |
171 ExpectFeatures("TestFeature2", "TestFeature1"); | |
172 } | |
173 } | |
174 | |
175 TEST_F(ScopedFeatureListTest, FeatureOverrideKeepsOtherExistingDefaultFeature) { | |
176 test::ScopedFeatureList feature_list1; | |
177 feature_list1.InitFromCommandLine("*TestFeature1", std::string()); | |
178 | |
179 { | |
180 test::ScopedFeatureList feature_list2; | |
181 feature_list2.InitWithFeatures({}, {kTestFeature2}); | |
182 ExpectFeatures("*TestFeature1", "TestFeature2"); | |
183 } | |
184 } | |
185 | |
186 } // namespace test | |
187 } // namespace base | |
OLD | NEW |