Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

Issue 2834573005: Scrollbar no longer inherits from FrameViewBase. (Closed)
Patch Set: Update from upstream patch Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
diff --git a/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp b/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
index 39337a69e420f40098948a3cfcb08cfcf12b5f6d..10783c4b46e538d72323ff6b0c649606f7c2903a 100644
--- a/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
+++ b/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
@@ -63,7 +63,8 @@ Scrollbar::Scrollbar(ScrollableArea* scrollable_area,
&Scrollbar::AutoscrollTimerFired),
elastic_overscroll_(0),
track_needs_repaint_(true),
- thumb_needs_repaint_(true) {
+ thumb_needs_repaint_(true),
+ parent_(nullptr) {
theme_.RegisterScrollbar(*this);
// FIXME: This is ugly and would not be necessary if we fix cross-platform
@@ -74,7 +75,7 @@ Scrollbar::Scrollbar(ScrollableArea* scrollable_area,
theme_scrollbar_thickness_ = thickness;
if (chrome_client_)
thickness = chrome_client_->WindowToViewportScalar(thickness);
- FrameViewBase::SetFrameRect(IntRect(0, 0, thickness, thickness));
+ frame_rect_ = IntRect(0, 0, thickness, thickness);
current_pos_ = ScrollableAreaCurrentPos();
}
@@ -86,14 +87,14 @@ Scrollbar::~Scrollbar() {
DEFINE_TRACE(Scrollbar) {
visitor->Trace(scrollable_area_);
visitor->Trace(chrome_client_);
- FrameViewBase::Trace(visitor);
+ visitor->Trace(parent_);
}
void Scrollbar::SetFrameRect(const IntRect& frame_rect) {
- if (frame_rect == this->FrameRect())
+ if (frame_rect == frame_rect_)
return;
- FrameViewBase::SetFrameRect(frame_rect);
+ frame_rect_ = frame_rect;
SetNeedsPaintInvalidation(kAllParts);
if (scrollable_area_)
scrollable_area_->ScrollbarFrameRectChanged();

Powered by Google App Engine
This is Rietveld 408576698