Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2834573005: Scrollbar no longer inherits from FrameViewBase. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.h
diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h
index 9e3583212752a44cab63b5cdd2e045e8f2b3003a..061869d708f1de0111c96ba48d060c4c8b146b51 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.h
+++ b/third_party/WebKit/Source/core/frame/FrameView.h
@@ -471,6 +471,7 @@ class CORE_EXPORT FrameView final
typedef HeapHashSet<Member<FrameViewBase>> ChildrenSet;
typedef HeapHashSet<Member<PluginView>> PluginsSet;
+ typedef HeapHashSet<Member<Scrollbar>> ScrollbarsSet;
// Functions for child manipulation and inspection.
void SetParent(FrameViewBase*) override;
@@ -480,6 +481,9 @@ class CORE_EXPORT FrameView final
void RemovePlugin(PluginView*);
void AddPlugin(PluginView*);
const PluginsSet* Plugins() const { return &plugins_; }
+ void RemoveScrollbar(Scrollbar*);
+ void AddScrollbar(Scrollbar*);
+ const ScrollbarsSet* Scrollbars() const { return &scrollbars_; }
szager1 2017/04/21 08:37:52 Can this return a ScrollbarSet& instead?
joelhockey 2017/04/21 09:56:09 Yes. I will do a followup CL and I can make child
// If the scroll view does not use a native widget, then it will have
// cross-platform Scrollbars. These functions can be used to obtain those
@@ -1002,10 +1006,6 @@ class CORE_EXPORT FrameView final
void AdjustScrollOffsetFromUpdateScrollbars();
bool VisualViewportSuppliesScrollbars();
- bool IsFrameViewScrollbar(const FrameViewBase* child) const {
- return HorizontalScrollbar() == child || VerticalScrollbar() == child;
- }
-
ScrollingCoordinator* GetScrollingCoordinator() const;
void PrepareLayoutAnalyzer();
@@ -1125,6 +1125,7 @@ class CORE_EXPORT FrameView final
ChildrenSet children_;
PluginsSet plugins_;
+ ScrollbarsSet scrollbars_;
ScrollOffset pending_scroll_delta_;
ScrollOffset scroll_offset_;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698