Replace CompositorFrameSinkSupport::WillDrawSurface With RepeatingCallback

cc/surfaces/surface_aggregator.cc

Index: cc/surfaces/surface_aggregator.cc
diff --git a/cc/surfaces/surface_aggregator.cc b/cc/surfaces/surface_aggregator.cc
index 526b19324e9c76284fa9fee72ff76dfed6956690..112e8e77624384398cf6d59654d83332e81f9940 100644
--- a/cc/surfaces/surface_aggregator.cc
+++ b/cc/surfaces/surface_aggregator.cc
@@ -759,10 +759,8 @@ gfx::Rect SurfaceAggregator::PrewalkTree(const SurfaceId& surface_id,
   }
 
   CHECK(debug_weak_this.get());
-  if (surface->factory()) {
-    surface->factory()->WillDrawSurface(
-        surface->surface_id().local_surface_id(), damage_rect);
-  }
+  if (!damage_rect.IsEmpty())

[danakj, 2017/04/20 13:56:45]

Can you leave a TODO that this shouldn't need to call the callback when the
damage is from |surface| and not from |child_surfaces|?

[Alex Z., 2017/04/20 14:05:03]

Done.

+    surface->RunWillDrawCallbacks(damage_rect);

[danakj, 2017/04/20 13:56:45]

Also, DelegatedFrameHost doesn't need to check for an empty rect now.

[Alex Z., 2017/04/20 14:05:03]

Done. Does DFH need to check the local surface id? When would the DFH
have a different local surface id from the surface?

[danakj, 2017/04/20 14:18:43]

I'm not sure, you could look at when each is set to reason it out?

Also - are there no unit tests that verify that WillDraw happens, I didn't see
one here? Would you be able to add one if not?

[Alex Z., 2017/04/20 17:42:26]

DelegatedFrameHost updates local_surface_id_ in 
SubmitdCompositorFrame after submitting the frame to SurfaceFactory.
I replaced the if in DFH with a DCHECK and the check failed during
resizing. It seems that there a race.
SurfaceAggregatorTest.SimpleFrame verifies that WillDraw happens.

 
   CHECK(debug_weak_this.get());
   for (const auto& render_pass : frame.render_pass_list) {