Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: components/subresource_filter/content/browser/subresource_filter_safe_browsing_client_request.cc

Issue 2834543003: [subresource_filter] SB throttle can send multiple speculative requests. (Closed)
Patch Set: rebase on #468982 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/subresource_filter_safe_browsing_client_request.cc
diff --git a/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client_request.cc b/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client_request.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a7b477838ebf4ca808813ff8a1c1de8c3f7ec3e3
--- /dev/null
+++ b/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client_request.cc
@@ -0,0 +1,101 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/subresource_filter/content/browser/subresource_filter_safe_browsing_client_request.h"
+
+#include <utility>
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/location.h"
+#include "base/logging.h"
+#include "base/metrics/histogram_macros.h"
+#include "base/single_thread_task_runner.h"
+#include "components/subresource_filter/content/browser/subresource_filter_safe_browsing_client.h"
+#include "content/public/browser/browser_thread.h"
+
+namespace subresource_filter {
+
+constexpr base::TimeDelta
+ SubresourceFilterSafeBrowsingClientRequest::kCheckURLTimeout;
+
+SubresourceFilterSafeBrowsingClientRequest::
+ SubresourceFilterSafeBrowsingClientRequest(
+ const GURL& url,
+ size_t request_id,
+ scoped_refptr<safe_browsing::SafeBrowsingDatabaseManager>
+ database_manager,
+ scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
+ SubresourceFilterSafeBrowsingClient* client)
+ : url_(url),
+ request_id_(request_id),
+ database_manager_(std::move(database_manager)),
+ client_(client) {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+ timer_.SetTaskRunner(std::move(io_task_runner));
+}
+
+SubresourceFilterSafeBrowsingClientRequest::
+ ~SubresourceFilterSafeBrowsingClientRequest() {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+ if (!request_completed_)
+ database_manager_->CancelCheck(this);
+ timer_.Stop();
+}
+
+void SubresourceFilterSafeBrowsingClientRequest::Start() {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+ start_time_ = base::TimeTicks::Now();
+ if (database_manager_->CheckUrlForSubresourceFilter(url_, this)) {
+ SendCheckResultToClient(false /* served_from_network */,
+ safe_browsing::SB_THREAT_TYPE_SAFE,
+ safe_browsing::ThreatMetadata());
+ return;
+ }
+ timer_.Start(
+ FROM_HERE, kCheckURLTimeout,
+ base::Bind(&SubresourceFilterSafeBrowsingClientRequest::OnCheckUrlTimeout,
+ base::Unretained(this)));
+}
+
+void SubresourceFilterSafeBrowsingClientRequest::OnCheckBrowseUrlResult(
+ const GURL& url,
+ safe_browsing::SBThreatType threat_type,
+ const safe_browsing::ThreatMetadata& metadata) {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+ DCHECK_EQ(url_, url);
+ request_completed_ = true;
+ SendCheckResultToClient(true /* served_from_network */, threat_type,
+ metadata);
+}
+
+void SubresourceFilterSafeBrowsingClientRequest::OnCheckUrlTimeout() {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+ SendCheckResultToClient(true /* served_from_network */,
+ safe_browsing::SB_THREAT_TYPE_SAFE,
+ safe_browsing::ThreatMetadata());
+}
+
+void SubresourceFilterSafeBrowsingClientRequest::SendCheckResultToClient(
+ bool served_from_network,
+ safe_browsing::SBThreatType threat_type,
+ const safe_browsing::ThreatMetadata& metadata) {
+ SubresourceFilterSafeBrowsingClient::CheckResult result;
+ result.request_id = request_id_;
+ result.threat_type = threat_type;
+ result.pattern_type = metadata.threat_pattern_type;
+ result.check_time = base::TimeTicks::Now() - start_time_;
+
+ // This memeber is separate from |request_completed_|, in that it just
+ // indicates that this request is done processing (due to completion or
+ // timeout).
+ result.finished = true;
+
+ UMA_HISTOGRAM_TIMES("SubresourceFilter.SafeBrowsing.CheckTime",
+ result.check_time);
+ // Will delete |this|.
+ client_->OnCheckBrowseUrlResult(this, result);
+}
+
+} // namespace subresource_filter

Powered by Google App Engine
This is Rietveld 408576698