components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h - Issue 2834543003: [subresource_filter] SB throttle can send multiple speculative requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h

Issue 2834543003: [subresource_filter] SB throttle can send multiple speculative requests. (Closed)

Patch Set: reviews, etc Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/browser/BUILD.gn ('k') | components/subresource_filter/content/browser/fake_safe_browsing_database_manager.cc » ('j') | components/subresource_filter/content/browser/fake_safe_browsing_database_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h

diff --git a/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h b/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h

index ed4ccda41d160fa2103cb2d009e0072278416c13..f36c437d4ba1b1bf294b6fa08569440b20cbd65d 100644

--- a/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h

+++ b/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h

@@ -6,6 +6,7 @@

#define COMPONENTS_SUBRESOURCE_FILTER_CONTENT_BROWSER_FAKE_SAFE_BROWSING_DATABASE_MANAGER_H_

#include <map>

+#include <set>

#include "base/macros.h"

#include "components/safe_browsing_db/test_database_manager.h"

@@ -41,7 +42,10 @@ class FakeSafeBrowsingDatabaseManager

Client* client) override;

private:

+ void OnCheckUrlForSubresourceFilterComplete(Client* client, const GURL& url);

std::map<GURL, safe_browsing::SBThreatType> url_to_threat_type_;

+ std::set<Client*> checks_;

bool simulate_timeout_;

DISALLOW_COPY_AND_ASSIGN(FakeSafeBrowsingDatabaseManager);