Remove use of package:analyzer in dependency_grapher

Remove use of package:analyzer in dependency_grapher

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/4a197085329dd062f996e46f49c3356aab51e6a5

[Siggi Cherem (dart-lang), 2017-04-19 22:53:34]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2017-04-19 22:54:50]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2017-04-19 22:58:46]

sigmund@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2017-04-20 07:31:53]

Assuming you make the change below, lgtm.

https://codereview.chromium.org/2834543002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/directive_listener.dart (right):

https://codereview.chromium.org/2834543002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/directive_listener.dart:76:
_current.add(quotedString.substring(1, quotedString.length - 1));
We need to handle triple quotes and escaped characters in the string.

I believe this will work:

_current.add(unescapeString(token.lexeme));

Where unescapeString is defined in pkg/front_end/lib/src/fasta/quote.dart.

[Siggi Cherem (dart-lang), 2017-04-21 00:03:07]

https://codereview.chromium.org/2834543002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/directive_listener.dart (right):

https://codereview.chromium.org/2834543002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/directive_listener.dart:76:
_current.add(quotedString.substring(1, quotedString.length - 1));
On 2017/04/20 07:31:53, Paul Berry wrote:
> We need to handle triple quotes and escaped characters in the string.
> 
> I believe this will work:
> 
> _current.add(unescapeString(token.lexeme));
> 
> Where unescapeString is defined in pkg/front_end/lib/src/fasta/quote.dart.

Nice, thanks.

[Siggi Cherem (dart-lang), 2017-04-21 00:06:10]

Description was changed from

==========
Remove use of package:analyzer in dependency_grapher
==========

to

==========
Remove use of package:analyzer in dependency_grapher

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4a197085329dd062f996e46f49c3356aab51e6a5
==========

[Siggi Cherem (dart-lang), 2017-04-21 00:06:11]

Committed patchset #2 (id:60001) manually as
4a197085329dd062f996e46f49c3356aab51e6a5 (presubmit successful).