Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2834533002: Fix front-end tests: the original code is correct, this is a workaround for issue #29393 (Closed)

Created:
3 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix front-end tests: the original code is correct, this is a workaround for issue #29393 R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b57ca9fb55adb93acfa3038018b9e67a29581999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Siggi Cherem (dart-lang)
This fixes the failures introduced in cl/2826243002
3 years, 8 months ago (2017-04-19 22:24:13 UTC) #2
scheglov
LGTM
3 years, 8 months ago (2017-04-19 22:30:44 UTC) #3
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as b57ca9fb55adb93acfa3038018b9e67a29581999 (presubmit successful).
3 years, 8 months ago (2017-04-19 22:37:10 UTC) #5
Brian Wilkerson
3 years, 8 months ago (2017-04-19 22:41:56 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698