Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart

Issue 2834513004: Compete try-statements (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart
diff --git a/pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart b/pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart
index c95edd61fe7d31691d0295e5a907d284fe83f606..e3c6d8bec5c551d0c57c9854646f6d7ea95e668f 100644
--- a/pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart
+++ b/pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart
@@ -20,6 +20,7 @@ main() {
defineReflectiveTests(_IfCompletionTest);
defineReflectiveTests(_SimpleCompletionTest);
defineReflectiveTests(_SwitchCompletionTest);
+ defineReflectiveTests(_TryCompletionTest);
defineReflectiveTests(_WhileCompletionTest);
});
}
@@ -661,6 +662,215 @@ main() {
}
@reflectiveTest
+class _TryCompletionTest extends StatementCompletionTest {
+ test_catchOnly() async {
+ await _prepareCompletion(
+ 'catch',
+ '''
+main() {
+ try {
+ } catch(e){} catch ////
+}
+''',
+ atEnd: true);
+ _assertHasChange(
+ 'Complete try-statement',
+ '''
+main() {
+ try {
+ } catch(e){} catch () {
+ ////
+ }
+}
+''',
+ (s) => _after(s, 'catch ('));
+ }
+
+ test_finallyOnly() async {
+ await _prepareCompletion(
+ 'finally',
+ '''
+main() {
+ try {
+ } finally
+}
+''',
+ atEnd: true);
+ _assertHasChange(
+ 'Complete try-statement',
+ '''
+main() {
+ try {
+ } finally {
+ ////
+ }
+}
+''',
+ (s) => _after(s, ' '));
+ }
+
+ test_keywordOnly() async {
+ await _prepareCompletion(
+ 'try',
+ '''
+main() {
+ try////
+}
+''',
+ atEnd: true);
+ _assertHasChange(
+ 'Complete try-statement',
+ '''
+main() {
+ try {
+ ////
+ }
+}
+''',
+ (s) => _after(s, ' '));
+ }
+
+ test_keywordSpace() async {
+ await _prepareCompletion(
+ 'try',
+ '''
+main() {
+ try ////
+}
+''',
+ atEnd: true);
+ _assertHasChange(
+ 'Complete try-statement',
+ '''
+main() {
+ try {
+ ////
+ }
+}
+''',
+ (s) => _after(s, ' '));
+ }
+
+ test_onCatch() async {
+ await _prepareCompletion(
+ 'on',
+ '''
+main() {
+ try {
+ } on catch
+}
+''',
+ atEnd: true);
+ // It would be better to expect the cursor to follow the on-keyword but
+ // the parser thinks the exception type is 'catch' so it's kinda broken.
+ // See https://github.com/dart-lang/sdk/issues/29410
+ _assertHasChange(
+ 'Complete try-statement',
+ '''
+main() {
+ try {
+ } on catch () {
+ ////
+ }
+}
+''',
+ (s) => _after(s, 'catch ('));
+ }
+
+ test_onOnly() async {
+ await _prepareCompletion(
+ 'on',
+ '''
+main() {
+ try {
+ } on
+}
+''',
+ atEnd: true);
+ _assertHasChange(
+ 'Complete try-statement',
+ '''
+main() {
+ try {
+ } on {
+ ////
+ }
+}
+''',
+ (s) => _after(s, ' on '));
+ }
+
+ test_onSpace() async {
+ await _prepareCompletion(
+ 'on',
+ '''
+main() {
+ try {
+ } on ////
+}
+''',
+ atEnd: true);
+ _assertHasChange(
+ 'Complete try-statement',
+ '''
+main() {
+ try {
+ } on {
+ ////
+ }
+}
+''',
+ (s) => _after(s, ' on '));
+ }
+
+ test_onSpaces() async {
+ await _prepareCompletion(
+ 'on',
+ '''
+main() {
+ try {
+ } on ////
+}
+''',
+ atEnd: true);
+ _assertHasChange(
+ 'Complete try-statement',
+ '''
+main() {
+ try {
+ } on {
+ ////
+ }
+}
+''',
+ (s) => _after(s, ' on '));
+ }
+
+ test_onType() async {
+ await _prepareCompletion(
+ 'on',
+ '''
+main() {
+ try {
+ } on Exception
+}
+''',
+ atEnd: true);
+ _assertHasChange(
+ 'Complete try-statement',
+ '''
+main() {
+ try {
+ } on Exception {
+ ////
+ }
+}
+''',
+ (s) => _after(s, ' '));
+ }
+}
+
+@reflectiveTest
class _WhileCompletionTest extends StatementCompletionTest {
/*
The implementation of completion for while-statements is shared with
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698