Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: tools/perf/measurements/smoothness_unittest.py

Issue 2834503002: SmoothnessUnitTest/testSmoothness is flaky on linux. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import sys 4 import sys
5 import unittest 5 import unittest
6 6
7 from telemetry import decorators 7 from telemetry import decorators
8 from telemetry.page import page 8 from telemetry.page import page
9 from telemetry.testing import options_for_unittests 9 from telemetry.testing import options_for_unittests
10 from telemetry.testing import page_test_test_case 10 from telemetry.testing import page_test_test_case
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 actual_synthetic_delay = ( 103 actual_synthetic_delay = (
104 config.chrome_trace_config.category_filter.synthetic_delays) 104 config.chrome_trace_config.category_filter.synthetic_delays)
105 105
106 if expected_synthetic_delay != actual_synthetic_delay: 106 if expected_synthetic_delay != actual_synthetic_delay:
107 sys.stderr.write('Expected category filter: %s\n' % 107 sys.stderr.write('Expected category filter: %s\n' %
108 repr(expected_synthetic_delay)) 108 repr(expected_synthetic_delay))
109 sys.stderr.write('Actual category filter filter: %s\n' % 109 sys.stderr.write('Actual category filter filter: %s\n' %
110 repr(actual_synthetic_delay)) 110 repr(actual_synthetic_delay))
111 self.assertEquals(expected_synthetic_delay, actual_synthetic_delay) 111 self.assertEquals(expected_synthetic_delay, actual_synthetic_delay)
112 112
113 @decorators.Disabled('chromeos') # crbug.com/483212 113 # crbug.com/483212 and crbug.com/713260
114 @decorators.Disabled('chromeos', 'linux')
114 def testSmoothness(self): 115 def testSmoothness(self):
115 ps = self.CreateStorySetFromFileInUnittestDataDir('scrollable_page.html') 116 ps = self.CreateStorySetFromFileInUnittestDataDir('scrollable_page.html')
116 measurement = smoothness.Smoothness() 117 measurement = smoothness.Smoothness()
117 results = self.RunMeasurement(measurement, ps, options=self._options) 118 results = self.RunMeasurement(measurement, ps, options=self._options)
118 self.assertEquals(0, len(results.failures)) 119 self.assertEquals(0, len(results.failures))
119 120
120 frame_times = results.FindAllPageSpecificValuesNamed('frame_times') 121 frame_times = results.FindAllPageSpecificValuesNamed('frame_times')
121 self.assertEquals(len(frame_times), 1) 122 self.assertEquals(len(frame_times), 1)
122 self.assertGreater(frame_times[0].GetRepresentativeNumber(), 0) 123 self.assertGreater(frame_times[0].GetRepresentativeNumber(), 0)
123 124
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 max_frame_delay = results.FindAllPageSpecificValuesNamed('max_frame_delay') 161 max_frame_delay = results.FindAllPageSpecificValuesNamed('max_frame_delay')
161 self.assertEquals(1, len(max_frame_delay)) 162 self.assertEquals(1, len(max_frame_delay))
162 self.assertGreater(max_frame_delay[0].GetRepresentativeNumber, 0) 163 self.assertGreater(max_frame_delay[0].GetRepresentativeNumber, 0)
163 164
164 frame_lengths = results.FindAllPageSpecificValuesNamed('frame_lengths') 165 frame_lengths = results.FindAllPageSpecificValuesNamed('frame_lengths')
165 self.assertEquals(1, len(frame_lengths)) 166 self.assertEquals(1, len(frame_lengths))
166 self.assertGreater(frame_lengths[0].GetRepresentativeNumber, 0) 167 self.assertGreater(frame_lengths[0].GetRepresentativeNumber, 0)
167 168
168 def testCleanUpTrace(self): 169 def testCleanUpTrace(self):
169 self.TestTracingCleanedUp(smoothness.Smoothness, self._options) 170 self.TestTracingCleanedUp(smoothness.Smoothness, self._options)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698