MD Bookmarks: Pull context menu into separate element

chrome/browser/resources/md_bookmarks/command_manager.js

Index: chrome/browser/resources/md_bookmarks/command_manager.js
diff --git a/chrome/browser/resources/md_bookmarks/command_manager.js b/chrome/browser/resources/md_bookmarks/command_manager.js
new file mode 100644
index 0000000000000000000000000000000000000000..efad1e2ec83a5170f1148406f9243605c5bda737
--- /dev/null
+++ b/chrome/browser/resources/md_bookmarks/command_manager.js
@@ -0,0 +1,168 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+Polymer({
+  is: 'bookmarks-command-manager',
+
+  behaviors: [
+    bookmarks.StoreClient,
+  ],
+
+  properties: {
+    /** @type {Set<string>} */
+    menuIds_: Object,
+  },
+
+  attached: function() {
+    /** @private {function(!Event)} */
+    this.boundOnOpenItemMenu_ = this.onOpenItemMenu_.bind(this);
+    document.addEventListener('open-item-menu', this.boundOnOpenItemMenu_);
+  },
+
+  detached: function() {
+    document.removeEventListener('open-item-menu', this.boundOnOpenItemMenu_);
+  },
+
+  /**
+   * Display the command context menu at (|x|, |y|) in window co-ordinates.
+   * Commands will execute on the currently selected items.
+   * @param {number} x
+   * @param {number} y
+   */
+  openCommandMenuAtPosition: function(x, y) {
+    this.menuIds_ = this.getState().selection.items;
+    /** @type {!CrActionMenuElement} */ (this.$.dropdown)
+        .showAtPosition({top: y, left: x});
+  },
+
+  /**
+   * Display the command context menu positioned to cover the |target|
+   * element. Commands will execute on the currently selected items.
+   * @param {!Element} target
+   */
+  openCommandMenuAtElement: function(target) {
+    this.menuIds_ = this.getState().selection.items;
+    /** @type {!CrActionMenuElement} */ (this.$.dropdown).showAt(target);
+  },
+
+  closeCommandMenu: function() {
+    /** @type {!CrActionMenuElement} */ (this.$.dropdown).close();
+  },
+
+  ////////////////////////////////////////////////////////////////////////////
+  // Command handlers:
+
+  /**
+   * @param {Command} command
+   * @param {!Set<string>} itemIds
+   * @return {boolean}
+   */
+  canExecute: function(command, itemIds) {
+    switch (command) {
+      case Command.EDIT:
+        return itemIds.size == 1;
+      case Command.COPY:
+        return itemIds.size == 1 &&
+            this.containsMatchingNode_(itemIds, function(node) {
+              return !!node.url;

[calamity, 2017/04/27 03:42:04]

Wait, I should be able to copy multiple items, which may or may not be folders,
right?.

[tsergeant, 2017/04/27 04:08:37]

You can in the current BMM.

However, the new spec only shows "Copy URL" as in the menu for items (not for
folders), and the new string implies that you're only expected to do one at a
time. I interpreted this to mean we are meant to change the behavior, but I can
check with Alan if you'd like.

+            });
+      case Command.DELETE:
+        return true;
+      default:
+        return false;
+    }
+  },
+
+  /**
+   * @param {Command} command
+   * @param {!Set<string>} itemIds
+   */
+  handle: function(command, itemIds) {
+    switch (command) {
+      case Command.EDIT:
+        var id = Array.from(itemIds)[0];
+        /** @type {!BookmarksEditDialogElement} */ (this.$.editDialog.get())
+            .showEditDialog(this.getState().nodes[id]);
+        break;
+      case Command.COPY:
+        var idList = Array.from(itemIds);
+        chrome.bookmarkManagerPrivate.copy(idList, function() {
+          // TODO(jiaxi): Add toast later.
+        });
+        break;
+      case Command.DELETE:
+        // TODO(tsergeant): Filter IDs so we don't try to delete children of
+        // something else already being deleted.
+        chrome.bookmarkManagerPrivate.removeTrees(
+            Array.from(itemIds), function() {
+              // TODO(jiaxi): Add toast later.
+            });
+        break;
+    }
+
+  },
+
+  ////////////////////////////////////////////////////////////////////////////
+  // Private functions:
+
+  /**
+   * @param {!Set<string>} itemIds
+   * @param {function(BookmarkNode):boolean} predicate
+   * @return {boolean} True if any node in |itemIds| returns true for
+   *     |predicate|.
+   */
+  containsMatchingNode_: function(itemIds, predicate) {
+    var nodes = this.getState().nodes;
+
+    return Array.from(itemIds).some(function(id) {
+      return predicate(nodes[id]);
+    });
+  },
+
+  /**
+   * @param {Event} e
+   * @private
+   */
+  onOpenItemMenu_: function(e) {
+    if (e.detail.targetElement) {
+      this.openCommandMenuAtElement(e.detail.targetElement);
+    } else {
+      this.openCommandMenuAtPosition(e.detail.x, e.detail.y);
+    }
+  },
+
+  /**
+   * @param {Event} e
+   * @private
+   */
+  onCommandClick_: function(e) {
+    this.closeCommandMenu();
+    this.handle(e.target.getAttribute('command'), assert(this.menuIds_));
+  },
+
+  /**
+   * Close the menu on mousedown so clicks can propagate to the underlying UI.
+   * This allows the user to right click the list while a context menu is
+   * showing and get another context menu.
+   * @param {Event} e
+   * @private
+   */
+  onMenuMousedown_: function(e) {
+    if (e.path[0] != this.$.dropdown)
+      return;
+
+    this.$.dropdown.close();
+  },
+
+  /** @private */
+  getEditActionLabel_: function() {
+    if (this.menuIds_.size > 1)
+      return;
+
+    var id = Array.from(this.menuIds_)[0];
+    var itemUrl = this.getState().nodes[id].url;
+    var label = itemUrl ? 'menuEdit' : 'menuRename';
+    return loadTimeData.getString(label);
+  },
+});