Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html

Issue 2834493004: Convert constructor/audiobuffersource.html to use new Audit (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html b/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html
index ce52578c1a43c142015c18ddddc7558fd48876dd..ebe9a29e55a7c14f60ecbffe4901095eea039d6c 100644
--- a/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html
+++ b/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html
@@ -5,8 +5,8 @@
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script src="../resources/audit-util.js"></script>
- <script src="../resources/audio-testing.js"></script>
- <script src="audionodeoptions.js"></script>
+ <script src="../resources/audit.js"></script>
+ <script src="new-audionodeoptions.js"></script>
</head>
<body>
@@ -15,100 +15,58 @@
var audit = Audit.createTaskRunner();
- audit.defineTask("initialize", function (taskDone) {
- Should("context = new OfflineAudioContext(...)", function () {
- context = new OfflineAudioContext(1, 1, 48000);
- }).notThrow();
-
- taskDone();
+ audit.define('initialize', (task, should) => {
+ context = initializeContext(should);
+ task.done();
});
- audit.defineTask("invalid constructor", function (taskDone) {
- var node;
- var success = true;
-
- success = Should("new AudioBufferSourceNode()", function () {
- node = new AudioBufferSourceNode();
- }).throw("TypeError");
- success = Should("new AudioBufferSourceNode(1)", function () {
- node = new AudioBufferSourceNode(1) && success;
- }).throw("TypeError");
- success = Should("new AudioBufferSourceNode(c, 42)", function () {
- node = new AudioBufferSourceNode(context, 42) && success;
- }).throw("TypeError");
-
- Should("Invalid constructors", success)
- .summarize(
- "correctly threw errors",
- "did not throw errors in all cases");
-
- taskDone();
+ audit.define('invalid constructor', (task, should) => {
+ testInvalidConstructor(should, 'AudioBufferSourceNode', context);
+ task.done();
});
- audit.defineTask("default constructor", function (taskDone) {
- var node;
- var success = true;
-
- success = Should("node = new AudioBufferSourceNode(c)", function () {
- node = new AudioBufferSourceNode(context);
- }).notThrow() && success;
-
- success = Should("node instanceof AudioBufferSourceNode",
- node instanceof AudioBufferSourceNode).beEqualTo(true) && success;
-
- success = Should("node0.buffer === null", node.buffer === null)
- .beEqualTo(true) && success;
-
- // This node using the factory method is used as a reference for the
- // defautl values.
- var factoryNode = context.createBufferSource();
-
- var testAttributes = ["buffer", "detune", "loop", "loopEnd", "loopStart",
- "playbackRate"];
-
- for (var index in testAttributes) {
- var name = testAttributes[index];
-
- if (node[name] instanceof AudioParam) {
- success = Should("node0." + name + ".value", node[name].value)
- .beEqualTo(factoryNode[name].value) && success;
- } else {
- success = Should("node0." + name, node[name])
- .beEqualTo(factoryNode[name]) && success;
- }
- }
-
- Should("AudioBufferSourceNode constructed", success)
- .summarize("correctly", "incorrectly");
-
- taskDone();
+ audit.define('default constructor', (task, should) => {
+ let prefix = 'node0';
+ let node =
+ testDefaultConstructor(should, 'AudioBufferSourceNode', context, {
+ prefix: prefix,
+ numberOfInputs: 0,
+ numberOfOutputs: 1,
+ channelCount: 2,
+ channelCountMode: 'max',
+ channelInterpretation: 'speakers'
+ });
+
+ testDefaultAttributes(should, node, prefix, [
+ {name: 'buffer', value: null},
+ {name: 'detune', value: 0},
+ {name: 'loop', value: false},
+ {name: 'loopEnd', value: 0.0},
+ {name: 'loopStart', value: 0.0},
+ {name: 'playbackRate', value: 1.0},
+ ]);
+
+ task.done();
});
- audit.defineTask("nullable buffer", function (taskDone) {
+ audit.define('nullable buffer', (task, should) => {
var node;
- var success = true;
-
- var options = { buffer: null };
-
- success = Should("node1 = new AudioBufferSourceNode(c, " + JSON.stringify(options), function () {
- node = new AudioBufferSourceNode(context, options);
- }).notThrow();
+ var options = {buffer: null};
- success = Should("node1.buffer", node.buffer)
- .beEqualTo(null);
+ should(
+ () => {
+ node = new AudioBufferSourceNode(context, options);
+ },
+ 'node1 = new AudioBufferSourceNode(c, ' + JSON.stringify(options))
+ .notThrow();
- Should("Null buffer in constructor handled", success)
- .summarize(
- "correctly",
- "incorrectly");
+ should(node.buffer, 'node1.buffer').beEqualTo(null);
- taskDone();
+ task.done();
});
- audit.defineTask("constructor options", function (taskDone) {
+ audit.define('constructor options', (task, should) => {
var node;
- var success = true;
-
var buffer = context.createBuffer(2, 1000, context.sampleRate);
var options = {
@@ -120,11 +78,12 @@
playbackRate: .75
};
- message = "node = new AudioBufferSourceNode(c, " + JSON.stringify(options) + ")";
+ message = 'node = new AudioBufferSourceNode(c, ' +
hongchan 2017/04/21 20:48:51 Add let. Otherwise this will be a global.
Raymond Toy 2017/04/21 20:54:56 Done.
+ JSON.stringify(options) + ')';
- success = Should(message, function () {
+ should(() => {
node = new AudioBufferSourceNode(context, options);
- }).notThrow();
+ }, message).notThrow();
// Use the factory method to create an equivalent node and compare the
// results from the constructor against this node.
@@ -136,26 +95,21 @@
factoryNode.loopStart = options.loopStart;
factoryNode.playbackRate.value = options.playbackRate;
- success = Should("node2.buffer === buffer", node.buffer === buffer)
- .beEqualTo(true) && success;
- success = Should("node2.detune.value", node.detune.value)
- .beEqualTo(factoryNode.detune.value) && success;
- success = Should("node2.loop", node.loop)
- .beEqualTo(factoryNode.loop) && success;
- success = Should("node2.loopEnd", node.loopEnd)
- .beEqualTo(factoryNode.loopEnd) && success;
- success = Should("node2.loopStart", node.loopStart)
- .beEqualTo(factoryNode.loopStart) && success;
- success = Should("node2.playbackRate.value", node.playbackRate.value)
- .beEqualTo(factoryNode.playbackRate.value) && success;
-
- Should("AudioBufferSource with options cosntructed", success)
- .summarize("correctly", "incorrectly");
-
- taskDone();
+ should(node.buffer === buffer, 'node2.buffer === buffer')
+ .beEqualTo(true);
+ should(node.detune.value, 'node2.detune.value')
+ .beEqualTo(factoryNode.detune.value);
+ should(node.loop, 'node2.loop').beEqualTo(factoryNode.loop);
+ should(node.loopEnd, 'node2.loopEnd').beEqualTo(factoryNode.loopEnd);
+ should(node.loopStart, 'node2.loopStart')
+ .beEqualTo(factoryNode.loopStart);
+ should(node.playbackRate.value, 'node2.playbackRate.value')
+ .beEqualTo(factoryNode.playbackRate.value);
+
+ task.done();
});
- audit.runTasks();
+ audit.run();
</script>
</body>
</html>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698