third_party/WebKit/LayoutTests/fast/css-grid-layout/preferred-width-computed-after-layout.html - Issue 2834473003: [css-grid] Preemptively store intrinsic sizes during layout

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/preferred-width-computed-after-layout.html

Issue 2834473003: [css-grid] Preemptively store intrinsic sizes during layout (Closed)

Patch Set: Patch+Test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.h » ('j') | third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <link href="resources/grid.css" rel="stylesheet">

	3 <style>

	4 .flex {

	5 display: flex;

	6 flex-direction: column;

	7 width: 500px;

	8 }

	9

	10 input {

	11 margin: 10px;

	12 font: 10px/1 Ahem;

	13 }

	14 </style>

	15

	16 <script src="../../resources/testharness.js"></script>

	17 <script src="../../resources/testharnessreport.js"></script>

	18 <script src="../../resources/check-layout-th.js"></script>

	19

	20 <body onload="runTest()">

	21 <p>This test checks that preferred widths computations triggered after layout fo r flex items do not cause grid containers to shrink. The test PASS if you see a 10px black square inside a white box inside a gray box.</p>
	Manuel Rego 2017/04/24 09:08:23 Nit: As this is a testharness.js test, you'll actu Nit: As this is a testharness.js test, you'll actually see some PASS messages. Also I guess you'll see 2 boxes, not only one. I'd just remove this last sentence, but feel free to update it accordingly.
	22 <h3>Grid as flex item.</h3>

	23 <div class="flex">

	24 <div class="grid" data-expected-width="500">

	25 <input data-expected-width="480">

	26 </div>

	27 </div>

	28

	29 <h3>Grid as a child of a flex item.</h3>

	30 <div class="flex">

	31 <div>

	32 <div class="grid" data-expected-width="500">

	33 <input data-expected-width="480">

	34 </div>

	35 </div>

	36 </div>

	37 <div id="log"></div>

	38 </body>

	39

	40 <script>

	41 function runTest() {

	42 var inputs = document.getElementsByTagName("input");

	43 for (i = 0; i < inputs.length; ++i) {

	44 inputs[i].focus();

	45 document.execCommand('InsertText', false, 'X');

	46 }

	47 checkLayout('.grid');

	48 }

	49 </script>

OLD	NEW