components/sync/engine_impl/model_type_registry.cc - Issue 2834453006: [Sync] Update Type Info section of sync-internals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/model_type_registry.cc

Issue 2834453006: [Sync] Update Type Info section of sync-internals. (Closed)

Patch Set: Updating ToString methods to clearly always return a value for picky compilers. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/engine_impl/model_type_registry.cc

diff --git a/components/sync/engine_impl/model_type_registry.cc b/components/sync/engine_impl/model_type_registry.cc

index 7d15dd610422e49283b5ebc832dc479fda22e611..b6bc2e31a03ba31988af40cb60dafc0803876a2e 100644

--- a/components/sync/engine_impl/model_type_registry.cc

+++ b/components/sync/engine_impl/model_type_registry.cc

@@ -270,7 +270,9 @@ void ModelTypeRegistry::RequestEmitDebugInfo() {

for (const auto& kv : data_type_debug_info_emitter_map_) {

kv.second->EmitCommitCountersUpdate();

kv.second->EmitUpdateCountersUpdate();

- kv.second->EmitStatusCountersUpdate();

+ // Although this breaks encapsulation, don't emit status counters here.

+ // They've already been asked for manually on the UI thread because USS

+ // emitters don't have a working implementation yet.

}