Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: chrome/test/data/webui/print_preview.js

Issue 2834453004: Remove print preview scaling flag (Closed)
Patch Set: address comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_features.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/print_preview.js
diff --git a/chrome/test/data/webui/print_preview.js b/chrome/test/data/webui/print_preview.js
index e48f4cece004d47edd55e95917aafc2227963633..2743ce8ed98a97ae60ecaf0cfe1a9bf0ed4786c0 100644
--- a/chrome/test/data/webui/print_preview.js
+++ b/chrome/test/data/webui/print_preview.js
@@ -61,19 +61,15 @@ PrintPreviewWebUITest.prototype = {
* @override
*/
testGenPreamble: function() {
- // Enable print scaling and print as image for tests.
+ // Enable print as image for tests on non Windows/Mac.
+ GEN('#if !defined(OS_WINDOWS) && !defined(OS_MACOSX)');
GEN(' base::FeatureList::ClearInstanceForTesting();');
GEN(' std::unique_ptr<base::FeatureList>');
GEN(' feature_list(new base::FeatureList);');
- GEN(' char enabled_features[128] = {0};');
- GEN(' strcpy(enabled_features, features::kPrintScaling.name);');
- GEN('#if !defined(OS_WINDOWS) && !defined(OS_MACOSX)');
- GEN(' strcat(strcat(enabled_features, ","), ');
- GEN(' features::kPrintPdfAsImage.name);');
- GEN('#endif');
GEN(' feature_list->InitializeFromCommandLine(');
- GEN(' enabled_features, std::string());');
+ GEN(' features::kPrintPdfAsImage.name, std::string());');
GEN(' base::FeatureList::SetInstance(std::move(feature_list));');
+ GEN('#endif');
},
/**
« no previous file with comments | « chrome/common/chrome_features.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698