Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2834453004: Remove print preview scaling flag (Closed)
Patch Set: address comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2450 matching lines...) Expand 10 before | Expand all | Expand 10 after
2461 FEATURE_VALUE_TYPE(features::kModalPermissionPrompts)}, 2461 FEATURE_VALUE_TYPE(features::kModalPermissionPrompts)},
2462 #endif 2462 #endif
2463 #if !defined(OS_MACOSX) 2463 #if !defined(OS_MACOSX)
2464 {"permission-prompt-persistence-toggle", 2464 {"permission-prompt-persistence-toggle",
2465 flag_descriptions::kPermissionPromptPersistenceToggleName, 2465 flag_descriptions::kPermissionPromptPersistenceToggleName,
2466 flag_descriptions::kPermissionPromptPersistenceToggleDescription, 2466 flag_descriptions::kPermissionPromptPersistenceToggleDescription,
2467 kOsWin | kOsCrOS | kOsLinux | kOsAndroid, 2467 kOsWin | kOsCrOS | kOsLinux | kOsAndroid,
2468 FEATURE_VALUE_TYPE( 2468 FEATURE_VALUE_TYPE(
2469 features::kDisplayPersistenceToggleInPermissionPrompts)}, 2469 features::kDisplayPersistenceToggleInPermissionPrompts)},
2470 #endif 2470 #endif
2471 #if BUILDFLAG(ENABLE_PRINT_PREVIEW) 2471 #if BUILDFLAG(ENABLE_PRINT_PREVIEW) && !defined(OS_WIN) && !defined(OS_MACOSX)
2472 #if !defined(OS_WIN) && !defined(OS_MACOSX)
2473 {"print-pdf-as-image", flag_descriptions::kPrintPdfAsImageName, 2472 {"print-pdf-as-image", flag_descriptions::kPrintPdfAsImageName,
2474 flag_descriptions::kPrintPdfAsImageDescription, kOsDesktop, 2473 flag_descriptions::kPrintPdfAsImageDescription, kOsDesktop,
2475 FEATURE_VALUE_TYPE(features::kPrintPdfAsImage)}, 2474 FEATURE_VALUE_TYPE(features::kPrintPdfAsImage)},
2476 #endif // !defined(OS_WIN) && !defined(OS_MACOSX) 2475 #endif
2477 {"print-scaling", flag_descriptions::kPrintScalingName,
2478 flag_descriptions::kPrintScalingDescription, kOsDesktop,
2479 FEATURE_VALUE_TYPE(features::kPrintScaling)},
2480 #endif // BUILDFLAG(ENABLE_PRINT_PREVIEW)
2481 #if defined(OS_ANDROID) 2476 #if defined(OS_ANDROID)
2482 {"enable-consistent-omnibox-geolocation", 2477 {"enable-consistent-omnibox-geolocation",
2483 flag_descriptions::kEnableConsistentOmniboxGeolocationName, 2478 flag_descriptions::kEnableConsistentOmniboxGeolocationName,
2484 flag_descriptions::kEnableConsistentOmniboxGeolocationDescription, 2479 flag_descriptions::kEnableConsistentOmniboxGeolocationDescription,
2485 kOsAndroid, FEATURE_VALUE_TYPE(features::kConsistentOmniboxGeolocation)}, 2480 kOsAndroid, FEATURE_VALUE_TYPE(features::kConsistentOmniboxGeolocation)},
2486 {"concurrent-background-loading-on-svelte", 2481 {"concurrent-background-loading-on-svelte",
2487 flag_descriptions::kOfflinePagesSvelteConcurrentLoadingName, 2482 flag_descriptions::kOfflinePagesSvelteConcurrentLoadingName,
2488 flag_descriptions::kOfflinePagesSvelteConcurrentLoadingDescription, 2483 flag_descriptions::kOfflinePagesSvelteConcurrentLoadingDescription,
2489 kOsAndroid, 2484 kOsAndroid,
2490 FEATURE_VALUE_TYPE( 2485 FEATURE_VALUE_TYPE(
(...skipping 464 matching lines...) Expand 10 before | Expand all | Expand 10 after
2955 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2950 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2956 2951
2957 const FeatureEntry* GetFeatureEntries(size_t* count) { 2952 const FeatureEntry* GetFeatureEntries(size_t* count) {
2958 *count = arraysize(kFeatureEntries); 2953 *count = arraysize(kFeatureEntries);
2959 return kFeatureEntries; 2954 return kFeatureEntries;
2960 } 2955 }
2961 2956
2962 } // namespace testing 2957 } // namespace testing
2963 2958
2964 } // namespace about_flags 2959 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698