Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2834453002: Add support for reporting plugin data to instrumentation (Closed)

Created:
3 years, 8 months ago by Brian Wilkerson
Modified:
3 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for reporting plugin data to instrumentation R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a3102bf44189c7702b8de6a25c81224730678c34

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -2 lines) Patch
M pkg/analyzer/lib/instrumentation/instrumentation.dart View 4 chunks +84 lines, -0 lines 2 comments Download
M pkg/analyzer/test/instrumentation/instrumentation_test.dart View 2 chunks +76 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 8 months ago (2017-04-19 17:44:05 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2834453002/diff/1/pkg/analyzer/lib/instrumentation/instrumentation.dart File pkg/analyzer/lib/instrumentation/instrumentation.dart (right): https://codereview.chromium.org/2834453002/diff/1/pkg/analyzer/lib/instrumentation/instrumentation.dart#newcode221 pkg/analyzer/lib/instrumentation/instrumentation.dart:221: _instrumentationServer.log(_join(fields)); Why don't we check for null in ...
3 years, 8 months ago (2017-04-19 17:46:59 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2834453002/diff/1/pkg/analyzer/lib/instrumentation/instrumentation.dart File pkg/analyzer/lib/instrumentation/instrumentation.dart (right): https://codereview.chromium.org/2834453002/diff/1/pkg/analyzer/lib/instrumentation/instrumentation.dart#newcode221 pkg/analyzer/lib/instrumentation/instrumentation.dart:221: _instrumentationServer.log(_join(fields)); Done
3 years, 8 months ago (2017-04-19 18:01:13 UTC) #4
Brian Wilkerson
3 years, 8 months ago (2017-04-19 18:01:29 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a3102bf44189c7702b8de6a25c81224730678c34 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698