WIP CSSPropertyParserHelpers::ConsumeCommaSeparatedList template

third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/parser/CSSPropertyParser.h"
 
 #include <memory>
 #include "core/StylePropertyShorthand.h"
 #include "core/css/CSSBasicShapeValues.h"
 #include "core/css/CSSBorderImage.h"
@@ skipping 1668 matching lines @@
     case CSSPropertyWebkitLogicalHeight:
       return CSSPropertyLengthUtils::ConsumeWidthOrHeight(range_, *context_);
     case CSSPropertyScrollSnapDestination:
     case CSSPropertyObjectPosition:
     case CSSPropertyPerspectiveOrigin:
       return ConsumePosition(range_, context_->Mode(), UnitlessQuirk::kForbid);
     case CSSPropertyWebkitHyphenateCharacter:
     case CSSPropertyWebkitLocale:
       return ConsumeLocale(range_);
     case CSSPropertyAnimationDelay:
-    case CSSPropertyTransitionDelay:
-    case CSSPropertyAnimationDirection:
+    case CSSPropertyTransitionDelay: {
+      CSSValueList* list = CSSPropertyParserHelpers::ConsumeCommaSeparatedList(
+          range_, CSSPropertyParserHelpers::ConsumeTime, kValueRangeAll);
+      if (!IsValidAnimationPropertyList(property, *list))
+        return nullptr;
+      return list;
+    }
+    case CSSPropertyAnimationDirection: {
+      CSSValueList* list = CSSPropertyParserHelpers::ConsumeCommaSeparatedList(
+          range_, CSSPropertyParserHelpers::ConsumeIdent<
+                      CSSValueNormal, CSSValueAlternate, CSSValueReverse,
+                      CSSValueAlternateReverse>);
+      if (!IsValidAnimationPropertyList(property, *list))
+        return nullptr;
+      return list;
+    }
     case CSSPropertyAnimationDuration:
     case CSSPropertyTransitionDuration:
     case CSSPropertyAnimationFillMode:
-    case CSSPropertyAnimationIterationCount:
+      return ConsumeAnimationPropertyList(
+          property, range_, context_,
+          unresolved_property == CSSPropertyAliasWebkitAnimationName);
+    case CSSPropertyAnimationIterationCount: {
+      CSSValueList* list = CSSPropertyParserHelpers::ConsumeCommaSeparatedList(
+          range_, ConsumeAnimationIterationCount);
+      if (!IsValidAnimationPropertyList(property, *list))
+        return nullptr;
+      return list;
+    }
     case CSSPropertyAnimationName:
     case CSSPropertyAnimationPlayState:
     case CSSPropertyTransitionProperty:
     case CSSPropertyAnimationTimingFunction:
     case CSSPropertyTransitionTimingFunction:
+      // TODO(bugsnash): change this from default
       return ConsumeAnimationPropertyList(
           property, range_, context_,
           unresolved_property == CSSPropertyAliasWebkitAnimationName);
     case CSSPropertyGridColumnGap:
     case CSSPropertyGridRowGap:
       return ConsumeLengthOrPercent(range_, context_->Mode(),
                                     kValueRangeNonNegative);
     case CSSPropertyColor:
     case CSSPropertyBackgroundColor:
       return ConsumeColor(range_, context_->Mode(), InQuirksMode());
@@ skipping 1717 matching lines @@
     case CSSPropertyPlaceItems:
       return ConsumePlaceItemsShorthand(important);
     case CSSPropertyPlaceSelf:
       return ConsumePlaceSelfShorthand(important);
     default:
       return false;
   }
 }
 
 }  // namespace blink