Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/resources/settings/route.js

Issue 2834433002: MD Settings: ESLint --fix output, WIP. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/route.js
diff --git a/chrome/browser/resources/settings/route.js b/chrome/browser/resources/settings/route.js
index 8dfa435c8b8b74069c76a6b90e8600556136b6fd..778b1235d78ebd653b9586062123b8fc8d9c0169 100644
--- a/chrome/browser/resources/settings/route.js
+++ b/chrome/browser/resources/settings/route.js
@@ -289,7 +289,7 @@ cr.define('settings', function() {
return Route[key].path == canonicalPath;
});
- return !!matchingKey ? Route[matchingKey] : null;
dpapad 2017/04/19 17:48:22 http://eslint.org/docs/rules/no-extra-boolean-cast
Dan Beam 2017/04/19 19:04:40 compiler will whine in some cases
dpapad 2017/05/05 18:20:46 Done, turned this off for now.
+ return matchingKey ? Route[matchingKey] : null;
};
/**

Powered by Google App Engine
This is Rietveld 408576698